You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[JENKINS-18959] /log/all polluted with FINE* messages from other loggers #14781
If you define a custom logger that captures messages at FINE or below, they also appear in /log/all, which is confusing and clouds the main log display.
If you define a custom logger that captures messages at FINE or below, they also appear in /log/all, which is confusing and clouds the main log display.
Integrated in jenkins_main_trunk #2751[FIXED JENKINS-18959] /log/all should not show FINE messages from custom loggers. (Revision 010d9e9067b7fa3ce776ec5f76a6cc4d0fdff258)
Well /log/all never shows all log records; by default it always shows everything logged at INFO and above (after a fix I made a few months ago to not restrict it to hudson.* and jenkins.* namespaces); but then it was also showing FINE and lower records that were only being logged at all because other /log/* loggers had been configured to show them. This is because in java.util.logging, to receive log records you need to both set the level of the logger low enough and attach a handler to it, but these are separate acts: all handlers attached to the logger will receive the same records.
So this fix tries to avoid sending the finer log records to all when they are already being displayed somewhere else, currently just by limiting all to INFO and above. It probably needs some adjustment since you can also—IMHO quite confusingly—adjust levels of arbitrary loggers in the Jenkins UI without adding a /log/* logger.
Well /log/all never shows all log records; by default it always shows everything logged at INFO and above (after a fix I made a few months ago to not restrict it to hudson.* and jenkins.* namespaces); but then it was also showing FINE and lower records that were only being logged at all because other /log/* loggers had been configured to show them. This is because in java.util.logging, to receive log records you need to both set the level of the logger low enough and attach a handler to it, but these are separate acts: all handlers attached to the logger will receive the same records.
So this fix tries to avoid sending the finer log records to all when they are already being displayed somewhere else, currently just by limiting all to INFO and above. It probably needs some adjustment since you can also—IMHO quite confusingly—adjust levels of arbitrary loggers in the Jenkins UI without adding a /log/* logger.
Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/hudson/WebAppMain.java
http://jenkins-ci.org/commit/jenkins/8a45a9946caf132727b210a7d1786159e4a1d079
Log:
[FIXED JENKINS-18959] /log/all should not show FINE messages from custom loggers.
(cherry picked from commit 010d9e9067b7fa3ce776ec5f76a6cc4d0fdff258)
Activity
jenkins-infra-bot commentedon Jul 26, 2013
Raw content of original comment:
Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/hudson/WebAppMain.java
http://jenkins-ci.org/commit/jenkins/010d9e9067b7fa3ce776ec5f76a6cc4d0fdff258
Log:
[FIXED JENKINS-18959] /log/all should not show FINE messages from custom loggers.
jenkins-infra-bot commentedon Jul 26, 2013
Raw content of original comment:
Integrated in
jenkins_main_trunk #2751
[FIXED JENKINS-18959] /log/all should not show FINE messages from custom loggers. (Revision 010d9e9)
Result = SUCCESS
Jesse Glick : 010d9e9067b7fa3ce776ec5f76a6cc4d0fdff258
Files :
jenkins-infra-bot commentedon Jul 30, 2013
Raw content of original comment:
It's less confusing for /log/all not to show all logs?
jenkins-infra-bot commentedon Jul 30, 2013
Raw content of original comment:
Well /log/all never shows all log records; by default it always shows everything logged at INFO and above (after a fix I made a few months ago to not restrict it to hudson.* and jenkins.* namespaces); but then it was also showing FINE and lower records that were only being logged at all because other /log/* loggers had been configured to show them. This is because in java.util.logging, to receive log records you need to both set the level of the logger low enough and attach a handler to it, but these are separate acts: all handlers attached to the logger will receive the same records.
So this fix tries to avoid sending the finer log records to all when they are already being displayed somewhere else, currently just by limiting all to INFO and above. It probably needs some adjustment since you can also—IMHO quite confusingly—adjust levels of arbitrary loggers in the Jenkins UI without adding a /log/* logger.
jenkins-infra-bot commentedon Sep 17, 2013
Raw content of original comment:
Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/hudson/WebAppMain.java
http://jenkins-ci.org/commit/jenkins/8a45a9946caf132727b210a7d1786159e4a1d079
Log:
[FIXED JENKINS-18959] /log/all should not show FINE messages from custom loggers.
(cherry picked from commit 010d9e9)