[JENKINS-8438] Node names can be edited to include slashes and then cannot be removed

Using Hudson v1.392, I did the following:

Created a node with a valid name (e.g., "Key Manager Build")
Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")

I am now unable to edit or delete this node.

Originally reported by jrh3k5, imported from: Node names can be edited to include slashes and then cannot be removed

assignee: sogabe
status: Closed
priority: Major
component(s): core
resolution: Fixed
resolved: 2011-01-15T04:41:48+00:00
votes: 0
watchers: 0
imported: 2025-11-24

Raw content of original issue

Using Hudson v1.392, I did the following:

Created a node with a valid name (e.g., "Key Manager Build")
Edited the node name to something that should have been marked as invalid (e.g., "IdP / OAuth Build")

I am now unable to edit or delete this node.

scm_issue_link:

Original comment link

Raw content of original comment:

Code changed in hudson User: Seiji Sogabe Path: changelog.html core/src/main/java/hudson/slaves/NodeDescriptor.java core/src/main/resources/hudson/slaves/Messages.properties core/src/main/resources/hudson/slaves/Messages_ja.properties http://hudson-labs.org/commit/core/46f2f02f9dbea085e67ff70673f38644b14b4f01 Log: [FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed.

Code changed in hudson
User: Seiji Sogabe
Path:
changelog.html
core/src/main/java/hudson/slaves/NodeDescriptor.java
core/src/main/resources/hudson/slaves/Messages.properties
core/src/main/resources/hudson/slaves/Messages_ja.properties
http://hudson-labs.org/commit/core/46f2f02f9dbea085e67ff70673f38644b14b4f01
Log:
[FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed.

jrh3k5:

Original comment link

Raw content of original comment:

Just out of curiosity, is there anything, short of editing the underlying XML, that would allow me to fix the node name?

sogabe:

Original comment link

Raw content of original comment:

Edit your config.xml as follows and restart Hudson instance.


<hudson>
  :
  <slaves>
    <slave>
      <name>Win7</name>  // <-- Change this to correct name.
      <description>Windows 7</description>
      <remoteFS>/tmp</remoteFS>
      <numExecutors>1</numExecutors>
      <mode>NORMAL</mode>
      <retentionStrategy class="hudson.slaves.RetentionStrategy$Always"/>
    :

Edit your config.xml as follows and restart Hudson instance.

:

Win7 // <-- Change this to correct name.
Windows 7
/tmp
1
NORMAL

:

jrh3k5:

Original comment link
Raw content of original comment:
```
Awesome, thanks!
```

Awesome, thanks!

dogfood:

Original comment link

Raw content of original comment:

Integrated in hudson_main_trunk #450 [FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed.

Seiji Sogabe : Files :

core/src/main/resources/hudson/slaves/Messages.properties
core/src/main/java/hudson/slaves/NodeDescriptor.java
core/src/main/resources/hudson/slaves/Messages_ja.properties
changelog.html

Integrated in hudson_main_trunk #450
[FIXED JENKINS-8438] Node names can be edited to include slashes and then cannot be removed.

Seiji Sogabe :
Files :

core/src/main/resources/hudson/slaves/Messages.properties
core/src/main/java/hudson/slaves/NodeDescriptor.java
core/src/main/resources/hudson/slaves/Messages_ja.properties
changelog.html

Navigation Menu

Repository navigation

[JENKINS-8438] Node names can be edited to include slashes and then cannot be removed #15549

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[JENKINS-8438] Node names can be edited to include slashes and then cannot be removed #15549

Description

Activity

jenkins-infra-bot commented on Jan 15, 2011

jenkins-infra-bot commented on Jan 15, 2011

jenkins-infra-bot commented on Jan 15, 2011

jenkins-infra-bot commented on Jan 15, 2011

jenkins-infra-bot commented on Jan 20, 2011

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions