Skip to content

[JENKINS-11513] Textbox for numbers should be type=number #16191

Closed
Closed
[JENKINS-11513] Textbox for numbers should be type=number#16191
Labels
component:coreenhancementimported-jira-issuepriority:minorresolution:fixed

Description

@jenkins-infra-bot
jenkins-infra-bot
opened on Oct 27, 2011

Jenkins has sevral textboxes to input numbers,
for instance, "# of executors" and "Days to keep builds".
These input elements are currently .
If they are , modern browsers will provide a better UI.

Originally reported by ohtake_tomohiro, imported from: Textbox for numbers should be type=number
  • assignee: ohtake_tomohiro
  • status: Closed
  • priority: Minor
  • component(s): core
  • resolution: Fixed
  • resolved: 2011-11-07T23:02:56+00:00
  • votes: 0
  • watchers: 1
  • imported: 2025-11-24
Raw content of original issue 
Jenkins has sevral textboxes to input numbers,
for instance, "# of executors" and "Days to keep builds".
These input elements are currently <input type="text" />.
If they are <input type="number" />, modern browsers will provide a better UI.

Activity

  1. jenkins-infra-bot commented on Oct 27, 2011

    @jenkins-infra-bot
    jenkins-infra-bot
    on Oct 27, 2011
    Author
    ohtake_tomohiro:

    I have requested a pull.
    #298

  2. jenkins-infra-bot commented on Nov 7, 2011

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 7, 2011
    Author
    scm_issue_link:

    Code changed in jenkins
    User: OHTAKE Tomohiro
    Path:
    core/src/main/resources/lib/form/number.jelly
    http://jenkins-ci.org/commit/jenkins/fd7b09cf4be5745ce85ed689928b07753cd687da
    Log:
    [FIXED JENKINS-11513] Add f:number for

  3. Based on textbox.jelly
    • Attributes removed: autoCompleteField, autoCompleteDelimChar
  • jenkins-infra-bot
    closed this as completedon Nov 7, 2011

  • jenkins-infra-bot commented on Nov 7, 2011

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 7, 2011
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment: 
      Code changed in jenkins
User: OHTAKE Tomohiro
Path:
 war/src/main/webapp/scripts/hudson-behavior.js
http://jenkins-ci.org/commit/jenkins/597a7ddc0f85ea12d842e0ba23ab942ec1312a1a
Log:
  JENKINS-11513 Change error message from 'number' to 'integer'
      


        
	
      • hudson-behavior.js checks if value of INPUT.number is an integer
        • 
	
      • HTML5 <input type=number> checks if value of INPUT is a number (including floating point)
        • 
	
      • It's better to change error message for INPUT.number to 'integer'
        •

    Code changed in jenkins
    User: OHTAKE Tomohiro
    Path:
    war/src/main/webapp/scripts/hudson-behavior.js
    http://jenkins-ci.org/commit/jenkins/597a7ddc0f85ea12d842e0ba23ab942ec1312a1a
    Log:
    JENKINS-11513 Change error message from 'number' to 'integer'

    • hudson-behavior.js checks if value of INPUT.number is an integer
    • HTML5 checks if value of INPUT is a number (including floating point)
    • It's better to change error message for INPUT.number to 'integer'

  • jenkins-infra-bot commented on Nov 7, 2011

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 7, 2011
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment: 
      Code changed in jenkins
User: OHTAKE Tomohiro
Path:
 core/src/main/resources/hudson/PluginManager/advanced.jelly
 core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly
 core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly
 core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly
 core/src/main/resources/hudson/tasks/LogRotator/config.jelly
 core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
 core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy
 core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy
 core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy
 core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
 core/src/main/resources/lib/hudson/project/config-retryCount.jelly
http://jenkins-ci.org/commit/jenkins/8067940aadfe8dc73b5e166b7f4b0fc5be504468
Log:
  JENKINS-11513 Change f:textbox to f:number
      


        
	
      • Add min, max, step and clazz attributes if appropriate
        •

    Code changed in jenkins
    User: OHTAKE Tomohiro
    Path:
    core/src/main/resources/hudson/PluginManager/advanced.jelly
    core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly
    core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly
    core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly
    core/src/main/resources/hudson/tasks/LogRotator/config.jelly
    core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
    core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy
    core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy
    core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy
    core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
    core/src/main/resources/lib/hudson/project/config-retryCount.jelly
    http://jenkins-ci.org/commit/jenkins/8067940aadfe8dc73b5e166b7f4b0fc5be504468
    Log:
    JENKINS-11513 Change f:textbox to f:number

    • Add min, max, step and clazz attributes if appropriate

  • jenkins-infra-bot commented on Nov 7, 2011

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 7, 2011
    Author
    scm_issue_link:

    Code changed in jenkins
    User: OHTAKE Tomohiro
    Path:
    core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config.groovy
    http://jenkins-ci.org/commit/jenkins/a6af173ff8448b8c61ffe46a6c61a53411b7fe29
    Log:
    JENKINS-11513 type=number for "TCP port for JNLP slave agents"

  • jenkins-infra-bot commented on Nov 7, 2011

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 7, 2011
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Kohsuke Kawaguchi
    Path:
    changelog.html
    http://jenkins-ci.org/commit/jenkins/117ed693f1d8bed874e418659848cea5c5b1beac
    Log:
    [FIXED JENKINS-11513] recording the past 5 changes

    Compare: 92496f9...117ed69

  • jenkins-infra-bot commented on Nov 7, 2011

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 7, 2011
    Author
    dogfood:
    • Original comment link
    • Raw content of original comment: 
      Integrated in  jenkins_main_trunk #1271
     [FIXED JENKINS-11513] Add f:number for <input type="number />
JENKINS-11513 Change error message from 'number' to 'integer'
JENKINS-11513 Change f:textbox to f:number
JENKINS-11513 type=number for "TCP port for JNLP slave agents"
[FIXED JENKINS-11513] recording the past 5 changes
      


      Kohsuke Kawaguchi : fd7b09cf4be5745ce85ed689928b07753cd687da
Files : 
      

        
	
      • core/src/main/resources/lib/form/number.jelly
        • 

      



      Kohsuke Kawaguchi : 597a7ddc0f85ea12d842e0ba23ab942ec1312a1a
Files : 
      

        
	
      • war/src/main/webapp/scripts/hudson-behavior.js
        • 

      



      Kohsuke Kawaguchi : 8067940aadfe8dc73b5e166b7f4b0fc5be504468
Files : 
      

        
	
      • core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly
        • 
	
      • core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy
        • 
	
      • core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
        • 
	
      • core/src/main/resources/hudson/PluginManager/advanced.jelly
        • 
	
      • core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy
        • 
	
      • core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly
        • 
	
      • core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
        • 
	
      • core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly
        • 
	
      • core/src/main/resources/lib/hudson/project/config-retryCount.jelly
        • 
	
      • core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy
        • 
	
      • core/src/main/resources/hudson/tasks/LogRotator/config.jelly
        • 

      



      Kohsuke Kawaguchi : a6af173ff8448b8c61ffe46a6c61a53411b7fe29
Files : 
      

        
	
      • core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config.groovy
        • 

      



      Kohsuke Kawaguchi : 117ed693f1d8bed874e418659848cea5c5b1beac
Files : 
      

        
	
      • changelog.html
        •

    Integrated in jenkins_main_trunk #1271
    [FIXED JENKINS-11513] Add f:number for JENKINS-11513 Change error message from 'number' to 'integer'
    JENKINS-11513 Change f:textbox to f:number
    JENKINS-11513 type=number for "TCP port for JNLP slave agents"
    [FIXED JENKINS-11513] recording the past 5 changes

    Kohsuke Kawaguchi : fd7b09cf4be5745ce85ed689928b07753cd687da
    Files :

    • core/src/main/resources/lib/form/number.jelly

    Kohsuke Kawaguchi : 597a7ddc0f85ea12d842e0ba23ab942ec1312a1a
    Files :

    • war/src/main/webapp/scripts/hudson-behavior.js

    Kohsuke Kawaguchi : 8067940aadfe8dc73b5e166b7f4b0fc5be504468
    Files :

    • core/src/main/resources/hudson/slaves/SimpleScheduledRetentionStrategy/config.jelly
    • core/src/main/resources/jenkins/model/GlobalQuietPeriodConfiguration/config.groovy
    • core/src/main/resources/hudson/triggers/SCMTrigger/global.jelly
    • core/src/main/resources/hudson/PluginManager/advanced.jelly
    • core/src/main/resources/jenkins/model/MasterBuildConfiguration/config.groovy
    • core/src/main/resources/hudson/slaves/RetentionStrategy/Demand/config.jelly
    • core/src/main/resources/lib/hudson/project/config-quietPeriod.jelly
    • core/src/main/resources/hudson/slaves/DumbSlave/configure-entries.jelly
    • core/src/main/resources/lib/hudson/project/config-retryCount.jelly
    • core/src/main/resources/jenkins/model/GlobalSCMRetryCountConfiguration/config.groovy
    • core/src/main/resources/hudson/tasks/LogRotator/config.jelly

    Kohsuke Kawaguchi : a6af173ff8448b8c61ffe46a6c61a53411b7fe29
    Files :

    • core/src/main/resources/hudson/security/GlobalSecurityConfiguration/config.groovy

    Kohsuke Kawaguchi : 117ed693f1d8bed874e418659848cea5c5b1beac
    Files :

    • changelog.html
  • jenkins-infra-bot
    added
    imported-jira-issue
    component:core
    priority:minor
    enhancement
    resolution:fixed
    on Nov 24, 2025
    • Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      component:coreenhancementimported-jira-issuepriority:minorresolution:fixed

      Type

      No type

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions