[JENKINS-33704] Multiple calls to the CloudRetentionStrategy when removing a node

[jenkins-infra-bot]

If a node has a cloud retention strategy, calling removeNode will execute the cloud retention strategy. This could cause further node removal and further loops in the call chain.

Since the queue is locked, if node removal is expensive, then Jenkins can potentially appear down while the node removal is happening.

Version 1.642.1

---

Originally reported by mmitche, imported from: Multiple calls to the CloudRetentionStrategy when removing a node

• assignee: vlatombe
• status: Closed
• priority: Major
• component(s): core
• label(s): 2.504.1-fixed
• resolution: Fixed
• resolved: 2025-04-08T14:38:50+00:00
• votes: 0
• watchers: 5
• imported: 2025-11-24

Raw content of original issue

If a node has a cloud retention strategy, calling removeNode will execute the cloud retention strategy.  This could cause further node removal and further loops in the call chain.

Since the queue is locked, if node removal is expensive, then Jenkins can potentially appear down while the node removal is happening.

Version 1.642.1

1 attachment

• stack.txt

[jenkins-infra-bot]

• Remote links associated with this issue:

  • PR #​10494
  • PR-10529 - Set built-in executor count
  • PR-10538 - update computer configuration with new node definition

[jenkins-infra-bot]

stephenconnolly:

• Original comment link
• Raw content of original comment:

  Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA
  

Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

[jenkins-infra-bot]

markewaite:

• Original comment link
• Raw content of original comment:

  If this bug fix is backported to 2.504.1, the backport needs to include 3 pull requests related to the issue:
  
  
  	
  Ensures the Jenkins master computer number of executors is set appropriately #10529
  	
  [JENKINS-33704] Limit scope of Jenkins#updateComputerList to improve performance at scale #10494
  	
  [JENKINS-33704] Computer configuration not updated correctly after updating nodes #10538
  
  
  

If this bug fix is backported to 2.504.1, the backport needs to include 3 pull requests related to the issue:

• Ensures the Jenkins master computer number of executors is set appropriately #10529
• [JENKINS-33704] Limit scope of Jenkins#updateComputerList to improve performance at scale #10494
• [JENKINS-33704] Computer configuration not updated correctly after updating nodes #10538

[jenkins-infra-bot]

catkingfirst:

• Original comment link
• Raw content of original comment:

  It's great. I'm suffering from this problem for a long time.Sometimes, Jenkins can not start new executions when cloud node is deleting.
  
  In old version, I use groovy script to remove these nodes and remove them on my cloud manager.
  

It's great. I'm suffering from this problem for a long time.Sometimes, Jenkins can not start new executions when cloud node is deleting.

In old version, I use groovy script to remove these nodes and remove them on my cloud manager.

[jenkins-infra-bot]

markewaite:

• Original comment link
• Raw content of original comment:

  catkingfirst have you verified that the changes fix the issue that you are having?  I don't see the relationship between your comment and the changes that were made to fix this issue.
  

catkingfirst have you verified that the changes fix the issue that you are having? I don't see the relationship between your comment and the changes that were made to fix this issue.

[jenkins-infra-bot]

catkingfirst:

• Original comment link
• Raw content of original comment:

  Alright, I've found the source of my problem, and it really has nothing to do with this. 
  

Alright, I've found the source of my problem, and it really has nothing to do with this.