Skip to content

[JENKINS-35452] Change Jnlp url from "slave-agent.jnlp" to "agent.jnlp" #17229

Closed

Description

@jenkins-infra-bot

Found when launching a jnlp agent from command line:

"java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".

The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

I understand that filenames and urls are effectively part of the API and so changing them is problematic and could be considered out of scope.   But filenames and urls are also part of the end-user experience (the UI) for every Jenkins user. And the files and urls related to adding an agent are some of the first and most commonly used.


Originally reported by bitwiseman, imported from: Change Jnlp url from "slave-agent.jnlp" to "agent.jnlp"
  • status: Closed
  • priority: Major
  • component(s): core
  • label(s): 2.263.1-rejected, terminology
  • resolution: Fixed
  • resolved: 2020-10-27T16:33:01+00:00
  • votes: 4
  • watchers: 9
  • imported: 2025-11-24
Raw content of original issue

Found when launching a jnlp agent from command line:

"java ... -jnlpUrl http://localhost/computer/agent_name/slave-agent.jnlp"

The name of this file should match agreed naming guidelines - "agent.jnlp" or "jenkins-agent.jnlp".

The originally agreement was that the term slave would be removed from the UI, but left in the APIs to avoid breaking compatibility both for plugins and customer tools/scripts.   The problem is that line of where the UI stops and the API begins is a somewhat fluid when your users are engineers.

I understand that filenames and urls are effectively part of the API and so changing them is problematic and could be considered out of scope.   But filenames and urls are also part of the end-user experience (the UI) for every Jenkins user. And the files and urls related to adding an agent are some of the first and most commonly used.

  • environment: Jenkins 2.6

Activity

  1. jenkins-infra-bot commented on Feb 28, 2017

    @jenkins-infra-bot
    Author
    oleg_nenashev:
    • Original comment link
    • Raw content of original comment:

      Not a bug. As a remoting maintainer I do not plan to work on it. The people responsible for the slave=>agent renaming decision implementation should drive it

    Not a bug.
    As a remoting maintainer I do not plan to work on it. The people responsible for the slave=>agent renaming decision implementation should drive it

  2. jenkins-infra-bot commented on Dec 20, 2017

    @jenkins-infra-bot
    Author
    annetheagile:

    oleg_nenashev the places to be changed would be found by this query, am I correct?

    https://github.com/jenkinsci/remoting/search?utf8=%E2%9C%93&q=slave&type=

  3. jenkins-infra-bot commented on Oct 27, 2020

    @jenkins-infra-bot
    Author
    oleg_nenashev:
    • Original comment link
    • Raw content of original comment:

      The fix has been released in Jenkins 2.264 . I will tag it as lts candidate so that we consider backporting to 2.263.1

    The fix has been released in Jenkins 2.264 . I will tag it as lts candidate so that we consider backporting to 2.263.1

  4. jenkins-infra-bot commented on Nov 20, 2020

    @jenkins-infra-bot
    Author
    olivergondza:

    Not including into 2.263.1 as the fix is pending polishing. #5062 (comment)

  5. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    Author

    [Original relates_to from Jira: JENKINS-31095]

  6. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    Author

    [Original relates_to from Jira: JENKINS-35449]

  7. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    Author

    [Original relates_to from Jira: JENKINS-35451]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions