Skip to content

[JENKINS-36593] ItemCategory exposes public static MIN_TOSHOW field to API #17322

Closed

Description

@jenkins-infra-bot

In 25f9c99 recena introduced a new "public static int MIN_TOSHOW = 1" field. So we have a constant, which can be occasionally modified by any API user.

This field is now a part of API, so we cannot easily convert it to final or make private. My proposal is to restrict it at least


Originally reported by oleg_nenashev, imported from: ItemCategory exposes public static MIN_TOSHOW field to API
  • assignee: oleg_nenashev
  • status: Resolved
  • priority: Minor
  • component(s): core
  • label(s): 2.7.2-fixed
  • resolution: Fixed
  • resolved: 2016-07-21T08:55:43+00:00
  • votes: 0
  • watchers: 1
  • imported: 2025-11-24
Raw content of original issue

In 25f9c99 recena introduced a new "public static int MIN_TOSHOW = 1" field. So we have a constant, which can be occasionally modified by any API user.

This field is now a part of API, so we cannot easily convert it to final or make private. My proposal is to restrict it at least

Activity

  1. jenkins-infra-bot commented on Jul 12, 2016

    @jenkins-infra-bot
    Author
    • Remote link associated with this issue:

  2. jenkins-infra-bot commented on Jul 12, 2016

    @jenkins-infra-bot
    Author
    recena:

    oleg_nenashev I sent my comments to the PR.

  3. jenkins-infra-bot commented on Jul 21, 2016

    @jenkins-infra-bot
    Author
    danielbeck:
    • Original comment link
    • Raw content of original comment:

      Fixed in 2.14 (2016/07/17)

    Fixed in 2.14 (2016/07/17)

  4. jenkins-infra-bot commented on Jul 21, 2016

    @jenkins-infra-bot
    Author
    danielbeck:
    • Original comment link
    • Raw content of original comment:

      olivergondza Should be expedited into 2.7.2 to prevent people from using it IMO.

    olivergondza Should be expedited into 2.7.2 to prevent people from using it IMO.

  5. removed
    bugFor changelog: Minor bug. Will be listed after features
    on Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions