Repository navigation
[JENKINS-36720] Investigate/cleanup spotbugs issues in Jenkins core #17340
Description
Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues.
TODOs:
- Remove filtering of medium-priority issues by setting Medium
- Investigate error codes, add low-important once to the ignore list
- Fix important issues in small pull requests
This task can be handled by multiple contributors!
Originally reported by 
oleg_nenashev, imported from: Investigate/cleanup spotbugs issues in Jenkins core
- assignee: stefan_spieker
- status: Open
- priority: Minor
- component(s): core
- label(s): hacktoberfest, newbie-friendly
- resolution: Unresolved
- votes: 0
- watchers: 6
- imported: 2025-11-24
Raw content of original issue
Currently FindBugs settings ignore all medium-priority issues. It's bad, because this level contains NPE checks and other serious issues.
TODOs:
- Remove filtering of medium-priority issues by setting <findbugs.threshold>Medium</findbugs.threshold>
- Investigate error codes, add low-important once to the ignore list
- Fix important issues in small pull requests
This task can be handled by multiple contributors!
Activity
jenkins-infra-bot commentedon Aug 19, 2016
Raw content of original comment:
The output is too long to be published as text, I'll attach it
Summary:
The output is too long to be published as text, I'll attach it
jenkins-infra-bot commentedon Apr 3, 2017
Raw content of original comment:
Code changed in jenkins
User: Oleg Nenashev
Path:
pom.xml
http://jenkins-ci.org/commit/jenkins/6ca0d754c5cba97613bc8b1e7b33327119fbf79c
Log:
JENKINS-36720 - FindBugs. Reduse threshold to Medium
jenkins-infra-bot commentedon Oct 16, 2017
Raw content of original comment:
It's actually newbie-friendly. Anyone can pick the core, run FindBugs and then cleanup something from the report. This issue is rather a milestone for such kind of activities
jenkins-infra-bot commentedon Sep 24, 2019
Raw content of original comment:
Is this done completely in 2.191, or just partially?
jenkins-infra-bot commentedon Sep 25, 2019
stefan_spieker:
Raw content of original comment:
There are several PRs done for this and there are more to come. This is a quite huge task. I think we would be down to 400 spotbugs issues if all PRs would be merged. So I guess this will be in progress for a longer while
jenkins-infra-bot commentedon Oct 2, 2019
Raw content of original comment:
I am thinking about Highlighting this story for Hacktoberfest. WDYT stefan_spieker?
jenkins-infra-bot commentedon Oct 2, 2019
stefan_spieker:
Raw content of original comment:
oleg_nenashev: Yes. That is a good idea. We have a lot issues still to solve. Maybe you should mention then that changing in the main pom the line 109 with this : Medium is enough to get all spotbugs issues.
jenkins-infra-bot commentedon Dec 23, 2019
stefan_spieker:
Raw content of original comment:
Current status:
[INFO] Total bugs: 400
jenkins-infra-bot commentedon Dec 23, 2019
Raw content of original comment:
Ugh. But it is still a very good progress, thanks!
jenkins-infra-bot commentedon Jan 11, 2020
stefan_spieker:
Raw content of original comment:
We are on a good way, but still some steps to go:
[java] Warnings generated: 362
jenkins-infra-bot commentedon Jan 11, 2020
Raw content of original comment:
Thanks for your hard work stefan_spieker! I really look forward to introduce stricter requirements at some point
jenkins-infra-bot commentedon Feb 20, 2020
raihaan:
Raw content of original comment:
Probably due to findsecbugs we are at [java] Warnings generated: 591 right now
jenkins-infra-bot commentedon Aug 18, 2024
Raw content of original comment:
The current spotbugs exclusion file for Jenkins core includes several items that need to be triaged. Items that need triage are in the section that starts with the text:
Items after that comment are examples of things to be reviewed as part of this issue.
bhumika-aga commentedon Jun 19, 2026
Raised a PR. Please have a look.
Triage NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE SpotBugs exclusions