[JENKINS-36757] incorrect logging formats in setup wizard.

[jenkins-infra-bot]

In 2.7.1 there are several incorrect logging statements which causes the message to be slightly less than useful.

$ grep -r -E -n "[^']'{[[:digit:]]"
hudson/model/UpdateCenter.java:1453:    LOGGER.log(WARNING, "Update site '{0}' does not declare the connection check URL. "
jenkins/install/InstallState.java:176:    LOGGER.log(Level.WARNING, "Read install state with blank name: '{0}'. It will be ignored", name);
jenkins/install/InstallState.java:182:    LOGGER.log(Level.WARNING, "Cannot locate an extension point for the state '{0}'. It will be ignored", name);

The idea here was presumable to put something in single quotes - however a message format requires a quote to be escaped - or it means use whatever is between the quotes without interpretation.

So you end up with log messages like:

Jul 18, 2016 1:52:58 PM hudson.model.UpdateCenter$ConnectionCheckJob run
WARNING: Update site {0} does not declare the connection check URL. Skipping the network availability check.

---

Originally reported by teilo, imported from: incorrect logging formats in setup wizard.

• status: Resolved
• priority: Minor
• component(s): core
• label(s): 2.7.3-fixed
• resolution: Fixed
• resolved: 2020-07-06T14:11:42+00:00
• votes: 0
• watchers: 4
• imported: 2025-11-24

Raw content of original issue

In 2.7.1 there are several incorrect logging statements which causes the message to be slightly less than useful.


$ grep -r -E -n "[^']'{[[:digit:]]"
hudson/model/UpdateCenter.java:1453:                    LOGGER.log(WARNING, "Update site '{0}' does not declare the connection check URL. "
jenkins/install/InstallState.java:176:            LOGGER.log(Level.WARNING, "Read install state with blank name: '{0}'. It will be ignored", name);
jenkins/install/InstallState.java:182:            LOGGER.log(Level.WARNING, "Cannot locate an extension point for the state '{0}'. It will be ignored", name);


The idea here was presumable to put something in single quotes - however a message format requires a quote to be escaped - or it means use whatever is between the quotes without interpretation.
So you end up with log messages like:

Jul 18, 2016 1:52:58 PM hudson.model.UpdateCenter$ConnectionCheckJob run
WARNING: Update site {0} does not declare the connection check URL. Skipping the network availability check.

[jenkins-infra-bot]

• Remote link associated with this issue:

  • PR #​2494

[jenkins-infra-bot]

danielbeck:

• Original comment link
• Raw content of original comment:

  oleg_nenashev Is this fixed with your FindBugs fixes?
  

oleg_nenashev Is this fixed with your FindBugs fixes?

[jenkins-infra-bot]

oleg_nenashev:

• Original comment link
• Raw content of original comment:

  danielbeck Nope. This syntax is "valid" from FindBugs PoV. Likely it's a symbol escaping by quotes: https://github.com/oleg-nenashev/jenkins/blob/e5a728b394f29c69795f2336edf4c4868de3a980/core/src/main/java/hudson/model/UpdateCenter.java#L1453
  

danielbeck Nope. This syntax is "valid" from FindBugs PoV. Likely it's a symbol escaping by quotes: https://github.com/oleg-nenashev/jenkins/blob/e5a728b394f29c69795f2336edf4c4868de3a980/core/src/main/java/hudson/model/UpdateCenter.java#L1453

[jenkins-infra-bot]

teilo:

• Original comment link
• Raw content of original comment:

  to use a single quote ' in a message format you must use double single quotes ''
  

to use a single quote ' in a message format you must use double single quotes ''

[jenkins-infra-bot]

teilo:

• Original comment link
• Raw content of original comment:

  olivergondza Does not qualify for LTS as < 2 weeks but the logging was clearly wrong, it is a trivial fix and really helps supporting the product when things go wrong. 
  

olivergondza Does not qualify for LTS as < 2 weeks but the logging was clearly wrong, it is a trivial fix and really helps supporting the product when things go wrong.

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in jenkins
  User: James Nord
  Path:
   core/src/main/java/hudson/model/UpdateCenter.java
   core/src/main/java/jenkins/install/InstallState.java
   core/src/main/resources/lib/hudson/project/configurable_pt_BR.properties
  http://jenkins-ci.org/commit/jenkins/943d8203ecfee316ece4c77a8f52f6faef5d6abb
  Log:
    JENKINS-36757 don't quote a paramaterized message in UpdateCenter. (#2494)
  
  '
  {0}' is the literal string {0}
   in a message format - if you want to quote
  the parameter then you need to use double single quotes ''
  {0}
  ''
  (cherry picked from commit 03750c92ee4ba902027be444144542017c0ccf65)
  
  
  

Code changed in jenkins
User: James Nord
Path:
core/src/main/java/hudson/model/UpdateCenter.java
core/src/main/java/jenkins/install/InstallState.java
core/src/main/resources/lib/hudson/project/configurable_pt_BR.properties
http://jenkins-ci.org/commit/jenkins/943d8203ecfee316ece4c77a8f52f6faef5d6abb
Log:
JENKINS-36757 don't quote a paramaterized message in UpdateCenter. (#2494)

'

{0}' is the literal string {0}

in a message format - if you want to quote
the parameter then you need to use double single quotes ''

{0}

''
(cherry picked from commit 03750c9)