[JENKINS-40088] JSON serialization should not fail if a plugins action failed to serialize

[jenkins-infra-bot]

Context
If there is a problem with the serialization of an Action then the rest response should not fail. We are unable to control 1000s of plugins and it would be a shame if a single plugin failed and made Blue Ocean inaccessible.
A good example of this happening is JENKINS-40083.

If the serialization of an action fails, the logs should identify what plugin failed and link to its wiki page (I believe all of this info is available via the Plugin Manager API) and ask them to report the stack trace as a bug for that project.

Solution

---

Originally reported by jamesdumay, imported from: JSON serialization should not fail if a plugins action failed to serialize

• assignee: vivek
• status: Closed
• priority: Critical
• component(s): blueocean-plugin, core
• label(s): blueocean, rest, robustness, stapler
• resolution: Fixed
• resolved: 2017-03-10T17:37:22+00:00
• votes: 0
• watchers: 7
• imported: 2025-11-24

Raw content of original issue

Context
If there is a problem with the serialization of an Action then the rest response should not fail. We are unable to control 1000s of plugins and it would be a shame if a single plugin failed and made Blue Ocean inaccessible. 
A good example of this happening is JENKINS-40083.

If the serialization of an action fails, the logs should identify what plugin failed and link to its wiki page (I believe all of this info is available via the Plugin Manager API) and ask them to report the stack trace as a bug for that project.

Solution

[jenkins-infra-bot]

• Remote links associated with this issue:

  • White screen of death
  • Stapler PR 89
  • core PR 2722
  • CloudBees Internal OSS-1824

[jenkins-infra-bot]

michaelneale:

• Original comment link
• Raw content of original comment:

  jamesdumay do you want to write up to the mailing list what your proposed fix could be for this? 
  

jamesdumay do you want to write up to the mailing list what your proposed fix could be for this?

[jenkins-infra-bot]

michaelneale:

• Original comment link
• Raw content of original comment:

  This can't be closed as it is linked to as the resolving issue
  

This can't be closed as it is linked to as the resolving issue

[jenkins-infra-bot]

jglick:

• Original comment link
• Raw content of original comment:

  Linking to a proposed fix, or prototype of fix.
  

Linking to a proposed fix, or prototype of fix.

[jenkins-infra-bot]

jglick:

• Original comment link
• Raw content of original comment:

  JENKINS-40083 was an instance of this IIUC?
  

JENKINS-40083 was an instance of this IIUC?

[jenkins-infra-bot]

jglick:

• Original comment link
• Raw content of original comment:

  Filing under core as there (inside Stapler) is where the problem lies; whether or not Blue Ocean plugins should be contributing to the exact fix is under discussion. Moved lts-candidate label from JENKINS-40083; it missed 2.32.2, but if we act fast it might still make it into 2.32.3.
  

Filing under core as there (inside Stapler) is where the problem lies; whether or not Blue Ocean plugins should be contributing to the exact fix is under discussion. Moved lts-candidate label from JENKINS-40083; it missed 2.32.2, but if we act fast it might still make it into 2.32.3.

[jenkins-infra-bot]

jamesdumay:

• Original comment link
• Raw content of original comment:

  jglick adding back the blueocean-plugin component so we can track this in our backlog more easily, but yes I agree this is a core issue.
  

jglick adding back the blueocean-plugin component so we can track this in our backlog more easily, but yes I agree this is a core issue.

[jenkins-infra-bot]

jglick:

• Original comment link
• Raw content of original comment:

  Agreement with vivek and michaelneale was to start with the simple defense against having the entire response end with a 500, and then have a follow-up PR (best tracked in a linked issue I think) to create an SPI for customized serialization that Blue Ocean would implement to ensure that its own classes are not tolerant of errors.
  

Agreement with vivek and michaelneale was to start with the simple defense against having the entire response end with a 500, and then have a follow-up PR (best tracked in a linked issue I think) to create an SPI for customized serialization that Blue Ocean would implement to ensure that its own classes are not tolerant of errors.

[jenkins-infra-bot]

jamesdumay:

• Original comment link
• Raw content of original comment:

  vivek this is the WSOD issue
  

vivek this is the WSOD issue

[jenkins-infra-bot]

jamesdumay:

• Original comment link
• Raw content of original comment:

  Another incidence of this problem JENKINS-41459
  

Another incidence of this problem JENKINS-41459

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in jenkins
  User: Jesse Glick
  Path:
   changelog.html
  http://jenkins-ci.org/commit/jenkins/2f057b4edde450bb2e6fe86bcd02fd731c8dbc88
  Log:
    @daniel-beck’s 56da425 merging #2722 implied that JENKINS-40088 was fixed in 2.42; in fact it is toward 2.46.
  
  
  

Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
http://jenkins-ci.org/commit/jenkins/2f057b4edde450bb2e6fe86bcd02fd731c8dbc88
Log:
@​daniel-beck’s 56da425 merging #2722 implied that JENKINS-40088 was fixed in 2.42; in fact it is toward 2.46.

[jenkins-infra-bot]

jamesdumay:

• Original comment link
• Raw content of original comment:

  We are still tracking this one to fix in Blue Ocean.
  

We are still tracking this one to fix in Blue Ocean.

[jenkins-infra-bot]

olivergondza:

• Original comment link
• Raw content of original comment:

  Removing lts-candidate label as the core part seems done and made it to 2.46, witch is the LTS baseline.
  

Removing lts-candidate label as the core part seems done and made it to 2.46, witch is the LTS baseline.

[jenkins-infra-bot]

oleg_nenashev:

• Original comment link
• Raw content of original comment:

  Additional fix has been integrated towards Jenkins 2.74
  

Additional fix has been integrated towards Jenkins 2.74