[JENKINS-72370] SimpleScheduledRetentionStrategy isn't working with inbound agents #18821

How to reproduce

1. Create an agent with Launch method "Launch agent by connecting it to the controller"
2. Set Availability to "Bring this agent online according to a schedule"
   Configure Startup schedule to "0 0 * * *" and scheduled uptime to "5" (basically the agent should not accept tasks)
3. Connect the agent.
4. Create a freestyle job that should run on that agent exclusively
5. run the job

Expected result

the job never runs

Actual result

the job gets executed

Details

SimpleScheduledRetentionStrategy disconnects agents and then does computer.setAcceptingTasks(false)

After a few seconds after the disconnection, the agents java process reconnects the agent which also sets the setAcceptingTasks to true for the agent.

Fix

SimpleScheduledRetentionStrategy should implement isAcceptingTasks and remove the explicit calls to __ computer.setAcceptingTasks(false)

How to reproduce

	
Create an agent with Launch method "Launch agent by connecting it to the controller"
	
Set Availability to "Bring this agent online according to a schedule"
Configure Startup schedule to "0 0 * * *" and scheduled uptime to "5" (basically the agent should not accept tasks)
	
Connect the agent.
	
Create a freestyle job that should run on that agent exclusively
	
run the job



Expected result

the job never runs

Actual result

the job gets executed

 

Details

SimpleScheduledRetentionStrategy disconnects agents and then does computer.setAcceptingTasks(false)

After a few seconds after the disconnection, the agents java process reconnects the agent which also sets the setAcceptingTasks to true for the agent.

 

Fix

SimpleScheduledRetentionStrategy should implement isAcceptingTasks and remove the explicit calls to __ computer.setAcceptingTasks(false)

• environment: latest Jenkins core (2.433)