Skip to content

[JENKINS-72371] Improve Nodemonitor configuration #18822

Closed

Description

@jenkins-infra-bot

The configuration of node monitors is working strange I think.

Before each monitor is a checkbox. The purpose of the checkbox is to disable that the monitor takes agents offline. But this is not really intuitive. At first glance one might think it will disable the monitor completely and hide it from the computer overview page. But this is not the case. For Monitors, that only have informational character like the architecture monitor this has the only affect that the ordering of the monitors on the computer overview page changes.

And for monitors that have configuration it has the negative side effect that the configuration is not saved. E.g. I want to have the free disk space configured to 10GB but I don't want that the monitor takes my agents offline. This is not possible at the moment.

This lead to the java version monitor (from the versionscolumn-plugin) implement its own checkbox to take agents offline.

The configuration should be changed so that for monitors that can take agents offline, there is an additional checkbox ignored and it is ensured that the configuration for each monitor is always saved.

Optionally making the monitors sortable might be also considered.


Originally reported by mawinter69, imported from: Improve Nodemonitor configuration
  • assignee: mawinter69
  • status: Closed
  • priority: Minor
  • component(s): core
  • resolution: Fixed
  • resolved: 2023-12-18T19:42:16+00:00
  • votes: 0
  • watchers: 1
  • imported: 2025-11-24
Raw content of original issue

The configuration of node monitors is working strange I think.

Before each monitor is a checkbox. The purpose of the checkbox is to disable that the monitor takes agents offline. But this is not really intuitive. At first glance one might think it will disable the monitor completely and hide it from the computer overview page. But this is not the case. For Monitors, that only have informational character like the architecture monitor this has the only affect that the ordering of the monitors on the computer overview page changes.

And for monitors that have configuration it has the negative side effect that the configuration is not saved. E.g. I want to have the free disk space configured to 10GB but I don't want that the monitor takes my agents offline. This is not possible at the moment.

This lead to the java version monitor (from the versionscolumn-plugin) implement its own checkbox to take agents offline.

The configuration should be changed so that for monitors that can take agents offline, there is an additional checkbox ignored and it is ensured that the configuration for each monitor is always saved.

Optionally making the monitors sortable might be also considered.

Activity

  1. jenkins-infra-bot commented on Nov 24, 2023

    @jenkins-infra-bot
    Author
    • Remote link associated with this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions