Repository navigation
[JENKINS-3964] Regression in user name handling: "Bob <bob@x.com>" -> "Bob _bob@x.com>" #18888
Description
Between 1.309 and 1.313, display of Mercurial users was broken. For example,
http://hg.netbeans.org/core-main/rev/3c5fac30b9a4
shows a user "Tomas Hurka " and changelog.xml contains this
name as well. But
http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/changes
shows "Tomas Hurka _thurka@netbeans.org>"
as does
http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/api/xml
so this broken name appears also in the NetBeans changelog view.
The culprit seems to be 18760 in User.java:
id = id.replace('
', '').replace('/', '').replace('<','_');
I am guessing that the correct fix is for the User constructor to take both id
and fullName params, with fullName being the unescaped original arg to User.get.
Originally reported by 
jglick, imported from: Regression in user name handling: "Bob " -> "Bob _bob@x.com>"
- status: Closed
- priority: Critical
- component(s): core
- resolution: Fixed
- resolved: 2009-06-30T09:33:12+00:00
- votes: 0
- watchers: 0
- imported: 2025-11-24
Raw content of original issue
Between 1.309 and 1.313, display of Mercurial users was broken. For example,
http://hg.netbeans.org/core-main/rev/3c5fac30b9a4
shows a user "Tomas Hurka <thurka@netbeans.org>" and changelog.xml contains this name as well. But
http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/changes
shows "Tomas Hurka _thurka@netbeans.org>"
as does
http://deadlock.netbeans.org/hudson/job/NB-Core-Build/2834/api/xml
so this broken name appears also in the NetBeans changelog view.
The culprit seems to be 18760 in User.java:
id = id.replace('
', '').replace('/', '').replace('<','_');I am guessing that the correct fix is for the User constructor to take both id and fullName params, with fullName being the unescaped original arg to User.get.
- environment:
Platform: All, OS: All
Activity
jenkins-infra-bot commentedon Jun 30, 2009
Raw content of original comment:
Code changed in hudson
User: : jglick
Path:
trunk/hudson/main/core/src/main/java/hudson/model/User.java
trunk/hudson/main/core/src/main/java/hudson/tasks/MailAddressResolver.java
http://fisheye4.cenqua.com/changelog/hudson/?cs=19322
Log:
[FIXED JENKINS-3964] Can escape characters in username to make an ID, but retain the original form for display & email purposes.
jenkins-infra-bot commentedon Jun 30, 2009
Raw content of original comment:
Code changed in hudson
User: : jglick
Path:
trunk/www/changelog.html
http://fisheye4.cenqua.com/changelog/hudson/?cs=19323
Log:
" -> "Bob _bob@x.com>"" class="issue-link" data-issue-key="JENKINS-3964">
JENKINS-3964Noting.