Skip to content

[JENKINS-7300] main/war/pom.xml uses non-standard maven directory layout #19777

Closed
Closed
[JENKINS-7300] main/war/pom.xml uses non-standard maven directory layout#19777
Labels
component:coreenhancementimported-jira-issuepriority:majorresolution:fixed

Description

@jenkins-infra-bot
jenkins-infra-bot
opened on Aug 25, 2010

Leftovers from the CVS days, according to Kohsuke, we have a lot of web resources which are in directories outside of src/main. As the old Japanese adage (roughly) says, "the nail that sticks out gets hammered".

Anyway, I have some ideas for resource filtering which become overly complicated when we break rank on where maven-war-plugin expects resources to be located. By moving these resources to the Maven standard directory layout, resource filtering issues will become quite simple.

According to Kohsuke, the images/ directory should remain in place despite it not being used within the WAR itself, so that should be left intact.

Originally reported by jieryn, imported from: main/war/pom.xml uses non-standard maven directory layout
  • assignee: jieryn
  • status: Closed
  • priority: Major
  • component(s): core
  • resolution: Fixed
  • resolved: 2010-08-25T11:08:33+00:00
  • votes: 0
  • watchers: 0
  • imported: 2025-11-24
Raw content of original issue 
Leftovers from the CVS days, according to Kohsuke, we have a lot of web resources which are in directories outside of src/main. As the old Japanese adage (roughly) says, "the nail that sticks out gets hammered".



Anyway, I have some ideas for resource filtering which become overly complicated when we break rank on where maven-war-plugin expects resources to be located. By moving these resources to the Maven standard directory layout, resource filtering issues will become quite simple.



According to Kohsuke, the images/ directory should remain in place despite it not being used within the WAR itself, so that should be left intact.

Activity

  1. jenkins-infra-bot commented on Aug 25, 2010

    @jenkins-infra-bot
    jenkins-infra-bot
    on Aug 25, 2010
    Author
    scm_issue_link:

    Code changed in hudson
    User: : jieryn
    Path:
    trunk/hudson/main/war/pom.xml
    http://jenkins-ci.org/commit/34095
    Log:
    JENKINS-7300 #resolve

  2. jenkins-infra-bot
    closed this as completedon Aug 25, 2010

  3. jenkins-infra-bot commented on Aug 26, 2010

    @jenkins-infra-bot
    jenkins-infra-bot
    on Aug 26, 2010
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment: 
      Code changed in hudson
User: : jieryn
Path:
 trunk/hudson/main/war/pom.xml
http://jenkins-ci.org/commit/34151
Log:
JENKINS-7300 #comment Andrew Bayer found a regression where our maven-hudson-dev-plugin was referencing the old ${basedir}/resources – remove the configuration option to reference the default src/main/webapp dir

    Code changed in hudson
    User: : jieryn
    Path:
    trunk/hudson/main/war/pom.xml
    http://jenkins-ci.org/commit/34151
    Log:
    JENKINS-7300 #comment Andrew Bayer found a regression where our maven-hudson-dev-plugin was referencing the old ${basedir}/resources – remove the configuration option to reference the default src/main/webapp dir

  4. jenkins-infra-bot commented on Sep 17, 2010

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 17, 2010
    Author
    s_baramov:

    Removing the env-vars.html breaks functionality on the job configuration page. When configuring an Ant job, the help text points to the https://hudson.dev.java.net/source/browse/*checkout*/hudson/trunk/hudson/main/war/resources/env-vars.html URL. Since the file was removed, the help content cannot be loaded.

  5. jenkins-infra-bot commented on Sep 17, 2010

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 17, 2010
    Author
    abayer:
    • Original comment link
    • Raw content of original comment: 
      Any chance you could give a screenshot?

    Any chance you could give a screenshot?

  6. jenkins-infra-bot commented on Sep 17, 2010

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 17, 2010
    Author
    abayer:
    • Original comment link
    • Raw content of original comment: 
      Ah, I found it. That's some weird code. Fixing it now. =)

    Ah, I found it. That's some weird code. Fixing it now. =)

  7. jenkins-infra-bot commented on Sep 17, 2010

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 17, 2010
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment: 
      Code changed in hudson
User: : abayer
Path:
 trunk/hudson/main/war/src/main/webapp/help/project-config/ant.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/ant_ja.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/maven.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/maven_de.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/maven_fr.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ja.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/maven_pt_BR.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ru.html
 trunk/hudson/main/war/src/main/webapp/help/project-config/maven_tr.html
http://jenkins-ci.org/commit/34963
Log:
[FIXED JENKINS-7300] Got rid of absolute paths to checkout paths at hudson.dev.java.net of env_vars.html

    Code changed in hudson
    User: : abayer
    Path:
    trunk/hudson/main/war/src/main/webapp/help/project-config/ant.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/ant_ja.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/maven.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/maven_de.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/maven_fr.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ja.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/maven_pt_BR.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ru.html
    trunk/hudson/main/war/src/main/webapp/help/project-config/maven_tr.html
    http://jenkins-ci.org/commit/34963
    Log:
    [FIXED JENKINS-7300] Got rid of absolute paths to checkout paths at hudson.dev.java.net of env_vars.html

  8. jenkins-infra-bot commented on Sep 17, 2010

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 17, 2010
    Author
    dogfood:
    • Original comment link
    • Raw content of original comment: 
      Integrated in  hudson_main_trunk #274
     [FIXED JENKINS-7300] Got rid of absolute paths to checkout paths at hudson.dev.java.net of env_vars.html
      


      abayer : 
Files : 
      

        
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_tr.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_fr.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/ant_ja.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_pt_BR.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/ant.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ja.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ru.html
        • 
	
      • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_de.html
        •

    Integrated in hudson_main_trunk #274
    [FIXED JENKINS-7300] Got rid of absolute paths to checkout paths at hudson.dev.java.net of env_vars.html

    abayer :
    Files :

    • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_tr.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_fr.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/ant_ja.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_pt_BR.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/ant.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ja.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_ru.html
    • /trunk/hudson/main/war/src/main/webapp/help/project-config/maven_de.html
  9. jenkins-infra-bot
    added
    imported-jira-issue
    component:core
    enhancement
    priority:major
    resolution:fixed
    on Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    component:coreenhancementimported-jira-issuepriority:majorresolution:fixed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions