[JENKINS-7378] StackOverflow at startup from LabelAtom.load

[jenkins-infra-bot]

hudson.model.Label.ConverterImpl does Hudson.getInstance().getLabel(reader.getValue()), presumably so there is a singleton instance of each Label type. However, when the Label is a LabelAtom this results in new LabelAtom() which calls load() which unmarshalls the object and returns to the getLabel call in ConverterImpl.. infinite loop, eventual StackOverflow.

---

Originally reported by mindless, imported from: StackOverflow at startup from LabelAtom.load

• assignee: mindless
• status: Resolved
• priority: Major
• component(s): core
• resolution: Fixed
• resolved: 2010-09-05T11:24:06+00:00
• votes: 0
• watchers: 0
• imported: 2025-11-24

Raw content of original issue

hudson.model.Label.ConverterImpl does Hudson.getInstance().getLabel(reader.getValue()), presumably so there is a singleton instance of each Label type.  However, when the Label is a LabelAtom this results in new LabelAtom() which calls load() which unmarshalls the object and returns to the getLabel call in ConverterImpl.. infinite loop, eventual StackOverflow.

[jenkins-infra-bot]

mindless:

• Original comment link
• Raw content of original comment:

  Perhaps LabelAtom.getConfigFile() should use a different XStream instance instead of Hudson.XSTREAM?  One that doesn't use Label.ConverterImpl.. then the LabelAtom.properties fields can save/load via RobustReflectionConverter.. is this the right approach?
  

Perhaps LabelAtom.getConfigFile() should use a different XStream instance instead of Hudson.XSTREAM? One that doesn't use Label.ConverterImpl.. then the LabelAtom.properties fields can save/load via RobustReflectionConverter.. is this the right approach?

[jenkins-infra-bot]

mindless:

• Original comment link
• Raw content of original comment:

  OK, I now remember that when I saw the new LabelAtom stuff and that a config page existed, just playing around I tried adding "/configure" on a "/label/foo" page, and submitting the form.. so I have a $HUDSON_HOME/labels/foo.xml file.. probably most people won't see this StackOverflow as they wouldn't have any existing xml files here..
  

OK, I now remember that when I saw the new LabelAtom stuff and that a config page existed, just playing around I tried adding "/configure" on a "/label/foo" page, and submitting the form.. so I have a $HUDSON_HOME/labels/foo.xml file.. probably most people won't see this StackOverflow as they wouldn't have any existing xml files here..

[jenkins-infra-bot]

mindless:

• Original comment link
• Raw content of original comment:

  Ok, I'm committing a fix using a separate XStream instance to avoid use of Label.ConverterImpl for LabelAtom.save/load.. feel free to refactor if there is a better way.
  

Ok, I'm committing a fix using a separate XStream instance to avoid use of Label.ConverterImpl for LabelAtom.save/load.. feel free to refactor if there is a better way.

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in hudson
  User: : mindless
  Path:
   trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java
  http://jenkins-ci.org/commit/34476
  Log:
  [FIXED JENKINS-7378] avoid StackOverflow error in LabelAtom.load
  

Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java
http://jenkins-ci.org/commit/34476
Log:
[FIXED JENKINS-7378] avoid StackOverflow error in LabelAtom.load

[jenkins-infra-bot]

dogfood:

• Original comment link
• Raw content of original comment:

  Integrated in  hudson_main_trunk #243
       [FIXED JENKINS-7378] avoid StackOverflow error in LabelAtom.load
  
  mindless : 
  Files : 
  
  	
  /trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java
  
  
  

Integrated in hudson_main_trunk #243
[FIXED JENKINS-7378] avoid StackOverflow error in LabelAtom.load

mindless :
Files :

• /trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in hudson
  User: : kohsuke
  Path:
   trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java
  http://jenkins-ci.org/commit/34591
  Log:
  JENKINS-7378 LabelProperties should be able to refer to other labels, and those things should be persisted as references, not as a bean.
  

Code changed in hudson
User: : kohsuke
Path:
trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java
http://jenkins-ci.org/commit/34591
Log:
JENKINS-7378 LabelProperties should be able to refer to other labels, and those things should be persisted as references, not as a bean.

[jenkins-infra-bot]

dogfood:

• Original comment link
• Raw content of original comment:

  Integrated in  hudson_main_trunk #250
       JENKINS-7378 LabelProperties should be able to refer to other labels, and those things should be persisted as references, not as a bean.
  
  kohsuke : 
  Files : 
  
  	
  /trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java
  
  
  

Integrated in hudson_main_trunk #250
JENKINS-7378 LabelProperties should be able to refer to other labels, and those things should be persisted as references, not as a bean.

kohsuke :
Files :

• /trunk/hudson/main/core/src/main/java/hudson/model/labels/LabelAtom.java