[JENKINS-29568] When NodeProvisioner processes planned nodes, it must always call spent() #21298

Activity

1. jenkins-infra-bot

   closed this as completedon Jul 22, 2015
2. jenkins-infra-bot commented on Jul 23, 2015

   

   jenkins-infra-bot

   on Jul 23, 2015

   Author

   More actions

   scm_issue_link:

   • Original comment link
   • Raw content of original comment:

     Code changed in jenkins
     User: Stephen Connolly
     Path:
      core/src/main/java/hudson/slaves/NodeProvisioner.java
     http://jenkins-ci.org/commit/jenkins/4f0ca16b01abcd5ac84a9259736c2d96b1712354
     Log:
       [FIXED JENKINS-29568] A better fix
     
     
     	
     252e1296099e838b8fba52221910442e0a757db4 doesn't work for all cases as there are code paths
       where a pending launch can be removed from the pending list and not have spent() called.
     	
     There was no reason for iterating the list twice anyway, as all of this takes place with the locks held
     	
     My notifying each one as we process, if there is an Error, we will not leave any stranded. The next run
       through, if there is one, will cover those instances.
     
     
     
     
     

   Code changed in jenkins
   User: Stephen Connolly
   Path:
   core/src/main/java/hudson/slaves/NodeProvisioner.java
   http://jenkins-ci.org/commit/jenkins/4f0ca16b01abcd5ac84a9259736c2d96b1712354
   Log:
   [FIXED JENKINS-29568] A better fix

   • 252e129 doesn't work for all cases as there are code paths
     where a pending launch can be removed from the pending list and not have spent() called.
   • There was no reason for iterating the list twice anyway, as all of this takes place with the locks held
   • My notifying each one as we process, if there is an Error, we will not leave any stranded. The next run
     through, if there is one, will cover those instances.
3. jenkins-infra-bot commented on Jul 23, 2015

   

   jenkins-infra-bot

   on Jul 23, 2015

   Author

   More actions

   dogfood:

   • Original comment link
   • Raw content of original comment:

     Integrated in  jenkins_main_trunk #4226
          [FIXED JENKINS-29568] A better fix (Revision 4f0ca16b01abcd5ac84a9259736c2d96b1712354)
     
          Result = UNSTABLE
     stephen connolly : 4f0ca16b01abcd5ac84a9259736c2d96b1712354
     Files : 
     
     	
     core/src/main/java/hudson/slaves/NodeProvisioner.java
     
     
     

   Integrated in jenkins_main_trunk #4226
   [FIXED JENKINS-29568] A better fix (Revision 4f0ca16)

   Result = UNSTABLE
   stephen connolly : 4f0ca16b01abcd5ac84a9259736c2d96b1712354
   Files :

   • core/src/main/java/hudson/slaves/NodeProvisioner.java
4. jenkins-infra-bot commented on Jul 23, 2015

   

   jenkins-infra-bot

   on Jul 23, 2015

   Author

   More actions

   stephenconnolly:

   • Original comment link
   • Raw content of original comment:

     Test failures are in completely unrelated code. 
     
     
     hudson.model.DownloadService2Test.updateNow
     hudson.model.UpdateCenter2Test.install
     hudson.model.UpdateCenterTest.data
     hudson.slaves.CommandLauncherTest.commandFails
     hudson.tasks.BuildTriggerTest.downstreamProjectShouldObserveCompletedParent
     
     
     Most likely a false warning possibly related to Jenkins infra outages as I have been seeing intermittent 503's on the main jenkins-ci.org today
     

   Test failures are in completely unrelated code.

   hudson.model.DownloadService2Test.updateNow
   hudson.model.UpdateCenter2Test.install
   hudson.model.UpdateCenterTest.data
   hudson.slaves.CommandLauncherTest.commandFails
   hudson.tasks.BuildTriggerTest.downstreamProjectShouldObserveCompletedParent
   

   Most likely a false warning possibly related to Jenkins infra outages as I have been seeing intermittent 503's on the main jenkins-ci.org today
5. jenkins-infra-bot commented on Jul 29, 2015

   

   jenkins-infra-bot

   on Jul 29, 2015

   Author

   More actions

   scm_issue_link:

   • Original comment link
   • Raw content of original comment:

     Code changed in jenkins
     User: Daniel Beck
     Path:
      changelog.html
     http://jenkins-ci.org/commit/jenkins/1598a464ff7973cbe6d3d6aa2493085a4a0646ec
     Log:
       Noting #1770 in 1.622, JENKINS-29568
     
     
     

   Code changed in jenkins
   User: Daniel Beck
   Path:
   changelog.html
   http://jenkins-ci.org/commit/jenkins/1598a464ff7973cbe6d3d6aa2493085a4a0646ec
   Log:
   Noting #1770 in 1.622, JENKINS-29568
6. jenkins-infra-bot commented on Aug 19, 2015

   

   jenkins-infra-bot

   on Aug 19, 2015

   Author

   More actions

   scm_issue_link:

   • Original comment link
   • Raw content of original comment:

     Code changed in jenkins
     User: Stephen Connolly
     Path:
      core/src/main/java/hudson/slaves/NodeProvisioner.java
     http://jenkins-ci.org/commit/jenkins/db1e2d2a199f7231f85809234cc1c703d3cb67a0
     Log:
       [FIXED JENKINS-29568] A better fix
     
     
     	
     252e1296099e838b8fba52221910442e0a757db4 doesn't work for all cases as there are code paths
       where a pending launch can be removed from the pending list and not have spent() called.
     	
     There was no reason for iterating the list twice anyway, as all of this takes place with the locks held
     	
     My notifying each one as we process, if there is an Error, we will not leave any stranded. The next run
       through, if there is one, will cover those instances.
     
     
     
     (cherry picked from commit 4f0ca16b01abcd5ac84a9259736c2d96b1712354)
     
     
     Compare: fea12f7...db1e2d2
     
     

   Code changed in jenkins
   User: Stephen Connolly
   Path:
   core/src/main/java/hudson/slaves/NodeProvisioner.java
   http://jenkins-ci.org/commit/jenkins/db1e2d2a199f7231f85809234cc1c703d3cb67a0
   Log:
   [FIXED JENKINS-29568] A better fix

   • 252e129 doesn't work for all cases as there are code paths
     where a pending launch can be removed from the pending list and not have spent() called.
   • There was no reason for iterating the list twice anyway, as all of this takes place with the locks held
   • My notifying each one as we process, if there is an Error, we will not leave any stranded. The next run
     through, if there is one, will cover those instances.

   (cherry picked from commit 4f0ca16)

   Compare: fea12f7...db1e2d2
7. jenkins-infra-bot commented on Sep 24, 2015

   

   jenkins-infra-bot

   on Sep 24, 2015

   Author

   More actions

   dogfood:

   • Original comment link
   • Raw content of original comment:

     Integrated in  jenkins_main_trunk #4292
          [FIXED JENKINS-29568] A better fix (Revision db1e2d2a199f7231f85809234cc1c703d3cb67a0)
     
          Result = UNSTABLE
     ogondza : db1e2d2a199f7231f85809234cc1c703d3cb67a0
     Files : 
     
     	
     core/src/main/java/hudson/slaves/NodeProvisioner.java
     
     
     

   Integrated in jenkins_main_trunk #4292
   [FIXED JENKINS-29568] A better fix (Revision db1e2d2)

   Result = UNSTABLE
   ogondza : db1e2d2a199f7231f85809234cc1c703d3cb67a0
   Files :

   • core/src/main/java/hudson/slaves/NodeProvisioner.java
8. jenkins-infra-bot

   added

   bugFor changelog: Minor bug. Will be listed after featuresFor changelog: Minor bug. Will be listed after features

   robustness

   imported-jira-issue

   component:core

   priority:major

   resolution:fixed

   on Nov 24, 2025
9. jenkins-infra-bot

   added the

   Bug

   issue type on Nov 25, 2025
10. jenkins-infra-bot

    removed

    bugFor changelog: Minor bug. Will be listed after featuresFor changelog: Minor bug. Will be listed after features

    on Nov 25, 2025