Skip to content

[JENKINS-42707] ReverseBuildTrigger can throw AccessDeniedException #21934

Closed

Description

@jenkins-infra-bot

Noticed in a console logs of an upstream job:

Notifying upstream projects of job completion 
FATAL: Please login to access job upstream 
org.acegisecurity.AccessDeniedException: Please login to access job upstream 
at jenkins.model.Jenkins.getItem(Jenkins.java:2724) 
at jenkins.model.Jenkins.getItem(Jenkins.java:324) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2830) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2849) 
at jenkins.triggers.ReverseBuildTrigger.shouldTrigger(ReverseBuildTrigger.java:116) 
at jenkins.triggers.ReverseBuildTrigger.access$000(ReverseBuildTrigger.java:89) 
at jenkins.triggers.ReverseBuildTrigger$1.shouldTriggerBuild(ReverseBuildTrigger.java:146) 
at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:247) 
at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:681) 
at hudson.model.Build$BuildExecution.cleanUp(Build.java:200) 
at hudson.model.Run.execute(Run.java:1775) 
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) 
at hudson.model.ResourceController.execute(ResourceController.java:98) 
at hudson.model.Executor.run(Executor.java:404) 
Notifying upstream projects of job completion 
FATAL: Please login to access job  
org.acegisecurity.AccessDeniedException: Please login to access job upstream 
at jenkins.model.Jenkins.getItem(Jenkins.java:2724) 
at jenkins.model.Jenkins.getItem(Jenkins.java:324) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2830) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2849) 
at jenkins.triggers.ReverseBuildTrigger.shouldTrigger(ReverseBuildTrigger.java:116) 
at jenkins.triggers.ReverseBuildTrigger.access$000(ReverseBuildTrigger.java:89) 
at jenkins.triggers.ReverseBuildTrigger$1.shouldTriggerBuild(ReverseBuildTrigger.java:146) 
at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:247) 
at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:681) 
at hudson.model.Build$BuildExecution.cleanUp(Build.java:200) 
at hudson.model.Run.execute(Run.java:1775) 
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) 
at hudson.model.ResourceController.execute(ResourceController.java:98) 
at hudson.model.Executor.run(Executor.java:404)

ReverseBuildTrigger.shouldTrigger should be impersonating SYSTEM.

This seems to happen because the anonymous user has Overall/Read and Item/Discover permission. The workaround is to remove the Item/Discover permission for the anonymous user.


Originally reported by allan_burdajewicz, imported from: ReverseBuildTrigger can throw AccessDeniedException
  • assignee: allan_burdajewicz
  • status: Resolved
  • priority: Major
  • component(s): core
  • label(s): 2.46.3-fixed
  • resolution: Fixed
  • resolved: 2017-05-05T14:14:01+00:00
  • votes: 2
  • watchers: 4
  • imported: 2025-11-24
Raw content of original issue

Noticed in a console logs of an upstream job:

Notifying upstream projects of job completion 
FATAL: Please login to access job upstream 
org.acegisecurity.AccessDeniedException: Please login to access job upstream 
at jenkins.model.Jenkins.getItem(Jenkins.java:2724) 
at jenkins.model.Jenkins.getItem(Jenkins.java:324) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2830) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2849) 
at jenkins.triggers.ReverseBuildTrigger.shouldTrigger(ReverseBuildTrigger.java:116) 
at jenkins.triggers.ReverseBuildTrigger.access$000(ReverseBuildTrigger.java:89) 
at jenkins.triggers.ReverseBuildTrigger$1.shouldTriggerBuild(ReverseBuildTrigger.java:146) 
at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:247) 
at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:681) 
at hudson.model.Build$BuildExecution.cleanUp(Build.java:200) 
at hudson.model.Run.execute(Run.java:1775) 
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) 
at hudson.model.ResourceController.execute(ResourceController.java:98) 
at hudson.model.Executor.run(Executor.java:404) 
Notifying upstream projects of job completion 
FATAL: Please login to access job <foldername> 
org.acegisecurity.AccessDeniedException: Please login to access job upstream 
at jenkins.model.Jenkins.getItem(Jenkins.java:2724) 
at jenkins.model.Jenkins.getItem(Jenkins.java:324) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2830) 
at jenkins.model.Jenkins.getItemByFullName(Jenkins.java:2849) 
at jenkins.triggers.ReverseBuildTrigger.shouldTrigger(ReverseBuildTrigger.java:116) 
at jenkins.triggers.ReverseBuildTrigger.access$000(ReverseBuildTrigger.java:89) 
at jenkins.triggers.ReverseBuildTrigger$1.shouldTriggerBuild(ReverseBuildTrigger.java:146) 
at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:247) 
at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:681) 
at hudson.model.Build$BuildExecution.cleanUp(Build.java:200) 
at hudson.model.Run.execute(Run.java:1775) 
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) 
at hudson.model.ResourceController.execute(ResourceController.java:98) 
at hudson.model.Executor.run(Executor.java:404)

ReverseBuildTrigger.shouldTrigger should be impersonating SYSTEM.

This seems to happen because the anonymous user has Overall/Read and Item/Discover permission. The workaround is to remove the Item/Discover permission for the anonymous user.

  • environment: Jenkins 2.32.3

Activity

  1. jenkins-infra-bot commented on Mar 13, 2017

    @jenkins-infra-bot
    Author
  2. jenkins-infra-bot commented on Mar 27, 2017

    @jenkins-infra-bot
    Author
    danielbeck:

    Does the fix for JENKINS-42556 take care of this?

  3. jenkins-infra-bot commented on Mar 30, 2017

    @jenkins-infra-bot
    Author
    jglick:
    • Original comment link
    • Raw content of original comment:

      Doubtful. This is an Executor thread, which should not have been affected by that fix.

    Doubtful. This is an Executor thread, which should not have been affected by that fix.

  4. jenkins-infra-bot commented on May 5, 2017

    @jenkins-infra-bot
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Allan Burdajewicz
    Path:
    core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
    test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
    http://jenkins-ci.org/commit/jenkins/17eedcfde8043829b247e639ae985ddb97dd0571
    Log:
    JENKINS-42707 AccessDeniedException exception in ReverseBuildTrigger (#2846)

    • JENKINS-42707 AccessDeniedException vulnerability in ReverseBuildTrigger.
    • JENKINS-42707 Log message according to permission (DISCOVER/READ)
  5. jenkins-infra-bot commented on Oct 11, 2017

    @jenkins-infra-bot
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Allan Burdajewicz
    Path:
    core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java
    test/src/test/java/jenkins/triggers/ReverseBuildTriggerTest.java
    http://jenkins-ci.org/commit/jenkins/7db9fe95669d426812dd4510b512fcd95ff1a64e
    Log:
    JENKINS-42707 AccessDeniedException exception in ReverseBuildTrigger (#2846)

    • JENKINS-42707 AccessDeniedException vulnerability in ReverseBuildTrigger.
    • JENKINS-42707 Log message according to permission (DISCOVER/READ)

    (cherry picked from commit 17eedcf)

  6. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    Author

    [Original relates_to from Jira: JENKINS-42586]

  7. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    Author

    [Original relates_to from Jira: JENKINS-42556]

  8. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    Author

    [Original relates_to from Jira: JENKINS-63868]

  9. removed
    bugFor changelog: Minor bug. Will be listed after features
    on Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions