[JENKINS-42969] Computer.addAction will throw UnsupportedOperationException

[jenkins-infra-bot]

The fix of JENKINS-39555 (in 2.30) reverted some of the code introduced in JENKINS-39404, to fix some regressions there. Unfortunately it failed to revert one of the simplifications that was legitimately made in JENKINS-39404 to code originally introduced in JENKINS-18224: so now Computer.addAction is again inherited from Actionable, but will not work since getActions is an immutable list.

Probably no one noticed this before because no one was trying to call Computer.addAction, but egutierrez noticed that yesterday's security release of ssh-slaves by mc1arke introduced code which does, and which causes a failure in TrustHostKeyActionTest.testSubmitNotAuthorised when run against 2.32.3:

java.lang.UnsupportedOperationException
	at java.util.Collections$UnmodifiableCollection.add(Collections.java:1055)
	at hudson.model.Actionable.addAction(Actionable.java:134)
	at hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy.verify(ManuallyTrustedKeyVerificationStrategy.java:70)

---

Originally reported by jglick, imported from: Computer.addAction will throw UnsupportedOperationException

• assignee: jglick
• status: Resolved
• priority: Critical
• component(s): core
• label(s): 2.46.2-fixed, regression
• resolution: Fixed
• resolved: 2017-03-23T16:05:04+00:00
• votes: 1
• watchers: 5
• imported: 2025-11-24

Raw content of original issue

The fix of JENKINS-39555 (in 2.30) reverted some of the code introduced in JENKINS-39404, to fix some regressions there. Unfortunately it failed to revert one of the simplifications that was legitimately made in JENKINS-39404 to code originally introduced in JENKINS-18224: so now Computer.addAction is again inherited from Actionable, but will not work since getActions is an immutable list.

Probably no one noticed this before because no one was trying to call Computer.addAction, but egutierrez noticed that yesterday's security release of ssh-slaves by mc1arke introduced code which does, and which causes a failure in TrustHostKeyActionTest.testSubmitNotAuthorised when run against 2.32.3:


java.lang.UnsupportedOperationException
	at java.util.Collections$UnmodifiableCollection.add(Collections.java:1055)
	at hudson.model.Actionable.addAction(Actionable.java:134)
	at hudson.plugins.sshslaves.verifiers.ManuallyTrustedKeyVerificationStrategy.verify(ManuallyTrustedKeyVerificationStrategy.java:70)

[jenkins-infra-bot]

• Remote links associated with this issue:

  • ssh-slaves PR 50
  • PR 2819
  • CloudBees Internal CLTS-1566

[jenkins-infra-bot]

danielbeck:

• Original comment link
• Raw content of original comment:

  Is there a change in the plugin possible to make this work for current LTS users?
  

Is there a change in the plugin possible to make this work for current LTS users?

[jenkins-infra-bot]

jglick:

• Original comment link
• Raw content of original comment:

  Yes, see plugin PR.
  

Yes, see plugin PR.

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in jenkins
  User: Jesse Glick
  Path:
   core/src/main/java/hudson/model/AbstractProject.java
   core/src/main/java/hudson/model/Computer.java
   core/src/main/java/hudson/model/labels/LabelAtom.java
   test/src/test/java/hudson/model/ComputerTest.java
  http://jenkins-ci.org/commit/jenkins/838357700d3173380170ecb28f131a554da0af63
  Log:
    [FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction.
  
  
  

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/java/hudson/model/AbstractProject.java
core/src/main/java/hudson/model/Computer.java
core/src/main/java/hudson/model/labels/LabelAtom.java
test/src/test/java/hudson/model/ComputerTest.java
http://jenkins-ci.org/commit/jenkins/838357700d3173380170ecb28f131a554da0af63
Log:
[FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction.

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in jenkins
  User: Jesse Glick
  Path:
   core/src/main/java/hudson/model/AbstractProject.java
   core/src/main/java/hudson/model/Computer.java
   core/src/main/java/hudson/model/labels/LabelAtom.java
   test/src/test/java/hudson/model/ComputerTest.java
  http://jenkins-ci.org/commit/jenkins/da67b374b0c1fa2875c8dac86acb03907d41ff2a
  Log:
    [FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction.
  (cherry picked from commit 838357700d3173380170ecb28f131a554da0af63)
  
  
  

Code changed in jenkins
User: Jesse Glick
Path:
core/src/main/java/hudson/model/AbstractProject.java
core/src/main/java/hudson/model/Computer.java
core/src/main/java/hudson/model/labels/LabelAtom.java
test/src/test/java/hudson/model/ComputerTest.java
http://jenkins-ci.org/commit/jenkins/da67b374b0c1fa2875c8dac86acb03907d41ff2a
Log:
[FIXED JENKINS-42969] UnsupportedOperationException from Computer.addAction.
(cherry picked from commit 8383577)

[jenkins-infra-bot]

[Original blocks from Jira: JENKINS-39555]

[jenkins-infra-bot]

[Original blocks from Jira: JENKINS-42968]