Skip to content

[JENKINS-43852] SecurityRealm captcha should use no-store as well as no cache in cache-control #22048

Closed

Description

@jenkins-infra-bot

looking at the code I think that the no-store option should be used in addition to the no-cache.

as navigating back or resubmitting the data will likely lead to an out of date captcha.


Originally reported by teilo, imported from: SecurityRealm captcha should use no-store as well as no cache in cache-control
  • assignee: wfollonier
  • status: Resolved
  • priority: Minor
  • component(s): core
  • label(s): 2.89.1-fixed, newbie-friendly, security
  • resolution: Fixed
  • resolved: 2017-11-13T07:26:14+00:00
  • votes: 1
  • watchers: 3
  • imported: 2025-11-24
Raw content of original issue

looking at the code I think that the no-store option should be used in addition to the no-cache.

as navigating back or resubmitting the data will likely lead to an out of date captcha.

Activity

  1. jenkins-infra-bot commented on Apr 26, 2017

    @jenkins-infra-bot
    Author
  2. jenkins-infra-bot commented on Nov 10, 2017

    @jenkins-infra-bot
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Wadeck Follonier
    Path:
    core/src/main/java/hudson/security/SecurityRealm.java
    test/src/test/java/hudson/security/SecurityRealmTest.java
    http://jenkins-ci.org/commit/jenkins/80d17f5a68739eafc27d5a3fd003b7eee4cfe8f3
    Log:
    JENKINS-43852 add caching options for captcha (#3126)

    • - remove whitespace
    • - correct unit tests
    • - copy/paste is bad
    • - second edit...
  3. jenkins-infra-bot commented on Nov 13, 2017

    @jenkins-infra-bot
    Author
    oleg_nenashev:
    • Original comment link
    • Raw content of original comment:

      The fix has been integrated towards 2.90

    The fix has been integrated towards 2.90

  4. jenkins-infra-bot commented on Nov 22, 2017

    @jenkins-infra-bot
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Wadeck Follonier
    Path:
    core/src/main/java/hudson/security/SecurityRealm.java
    test/src/test/java/hudson/security/SecurityRealmTest.java
    http://jenkins-ci.org/commit/jenkins/179ac8df0803375e4e600b7c44547419636d44fe
    Log:
    JENKINS-43852 add caching options for captcha (#3126)

    • - remove whitespace
    • - correct unit tests
    • - copy/paste is bad
    • - second edit...

    (cherry picked from commit 80d17f5)

  5. removed
    bugFor changelog: Minor bug. Will be listed after features
    on Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions