[JENKINS-47439] Jenkins 2.80 setup wizard does not resume after restart

[jenkins-infra-bot]

JENKINS-42577/ #3010 added saving of the Jenkins version whenever Jenkins is saved.

This caused the security issue JENKINS-47139, fixed by #3050

While that resolved the security issue that skips the wizard and its default protections, the setup wizard is still broken in a more subtle form:

In Jenkins 2.79, when restarting Jenkins while the setup wizard was unfinished, it would resume the setup wizard.

In Jenkins 2.81, when restarting Jenkins while the setup wizard was unfinished, it does not resume the setup wizard. While it still set the security defaults, and users can log in using 'admin' and the setup unlock code, it may not be clear to users that this works, and they just have a locked instance.

---

Originally reported by danielbeck, imported from: Jenkins 2.80 setup wizard does not resume after restart

• assignee: vlatombe
• status: Resolved
• priority: Major
• component(s): core
• label(s): 2.89.4-fixed, regression, setup-wizard, ux
• resolution: Fixed
• resolved: 2017-12-11T19:55:47+00:00
• votes: 0
• watchers: 2
• imported: 2025-11-24

Raw content of original issue

JENKINS-42577/ #3010 added saving of the Jenkins version whenever Jenkins is saved.

This caused the security issue JENKINS-47139, fixed by #3050

While that resolved the security issue that skips the wizard and its default protections, the setup wizard is still broken in a more subtle form:

In Jenkins 2.79, when restarting Jenkins while the setup wizard was unfinished, it would resume the setup wizard.

In Jenkins 2.81, when restarting Jenkins while the setup wizard was unfinished, it does not resume the setup wizard. While it still set the security defaults, and users can log in using 'admin' and the setup unlock code, it may not be clear to users that this works, and they just have a locked instance.

[jenkins-infra-bot]

• Remote links associated with this issue:

  • PR #​3166
  • CloudBees Internal TIGER-3979

[jenkins-infra-bot]

vlatombe:

• Original comment link
• Raw content of original comment:

  Proposed a PR
  

Proposed a PR

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in jenkins
  User: Vincent Latombe
  Path:
   core/src/main/java/hudson/util/PluginServletFilter.java
   core/src/main/java/jenkins/install/InstallState.java
   core/src/main/java/jenkins/install/InstallUtil.java
   core/src/main/java/jenkins/install/SetupWizard.java
   core/src/main/java/jenkins/model/Jenkins.java
   test/src/test/java/jenkins/install/SetupWizardRestartTest.java
  http://jenkins-ci.org/commit/jenkins/30ab4481f286a5c33499489dfcb9b3df6587ff38
  Log:
    [FIXES JENKINS-47439] Setup wizard does not resume after restart (#3166)
  
  
  	
  JENKINS-47439 Add a failing test
  
  
  
  On first startup, the setup wizard goes into state NEW and the filter to
  force display the setup wizard is installed.
  
  On second startup, the setup wizard goes into state RESTART (which
  assumes the setup wizard is done), and the setup wizard is skipped
  completely.
  
  This test expects that state NEW is retained upon restart when nothing
  is done.
  
  
  	
  JENKINS-47439 Persist InstallState
  
  
  
  In some cases, the heuristics to determine the current setup wizard state are
  fragile. It is safer to persist the install state so that upon restart,
  the setup wizard can resume where it was left off.
  
  
  	
  Missing javadoc and since for new public methods
  
  
  
  
  	
  s/XXX/FIXME/
  
  
  
  
  	
  Missed that one
  
  
  
  
  	
  Setup wizard filter should be removed when entering a state where setup is complete
  
  
  
  
  	
  Use parameterized logging
  
  
  
  
  	
  Improvements over previous impl
  
  
  
  
  	
  Removed static isUsingSecurityToken. Now only determined from install
  state.
  	
  Call onInstallStateUpdate before InstallState#initializeState as the
  latter can update state.
  
  
  
  
  	
  Triggering a new build
  
  
  
  
  

Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/java/hudson/util/PluginServletFilter.java
core/src/main/java/jenkins/install/InstallState.java
core/src/main/java/jenkins/install/InstallUtil.java
core/src/main/java/jenkins/install/SetupWizard.java
core/src/main/java/jenkins/model/Jenkins.java
test/src/test/java/jenkins/install/SetupWizardRestartTest.java
http://jenkins-ci.org/commit/jenkins/30ab4481f286a5c33499489dfcb9b3df6587ff38
Log:
[FIXES JENKINS-47439] Setup wizard does not resume after restart (#3166)

• JENKINS-47439 Add a failing test

On first startup, the setup wizard goes into state NEW and the filter to
force display the setup wizard is installed.

On second startup, the setup wizard goes into state RESTART (which
assumes the setup wizard is done), and the setup wizard is skipped
completely.

This test expects that state NEW is retained upon restart when nothing
is done.

• JENKINS-47439 Persist InstallState

In some cases, the heuristics to determine the current setup wizard state are
fragile. It is safer to persist the install state so that upon restart,
the setup wizard can resume where it was left off.

• Missing javadoc and since for new public methods

• s/XXX/FIXME/

• Missed that one

• Setup wizard filter should be removed when entering a state where setup is complete

• Use parameterized logging

• Improvements over previous impl

• Removed static isUsingSecurityToken. Now only determined from install
  state.
• Call onInstallStateUpdate before InstallState#initializeState as the
  latter can update state.

• Triggering a new build

[jenkins-infra-bot]

danielbeck:

• Original comment link
• Raw content of original comment:

  Merged towards 2.94.
  

Merged towards 2.94.

[jenkins-infra-bot]

scm_issue_link:

• Original comment link
• Raw content of original comment:

  Code changed in jenkins
  User: Vincent Latombe
  Path:
   core/src/main/java/hudson/util/PluginServletFilter.java
   core/src/main/java/jenkins/install/InstallState.java
   core/src/main/java/jenkins/install/InstallUtil.java
   core/src/main/java/jenkins/install/SetupWizard.java
   core/src/main/java/jenkins/model/Jenkins.java
   test/src/test/java/jenkins/install/SetupWizardRestartTest.java
  http://jenkins-ci.org/commit/jenkins/c359b86053dfe48c797f3b2135f72fb32cf8b609
  Log:
    [FIXES JENKINS-47439] Setup wizard does not resume after restart (#3166)
  
  
  	
  JENKINS-47439 Add a failing test
  
  
  
  On first startup, the setup wizard goes into state NEW and the filter to
  force display the setup wizard is installed.
  
  On second startup, the setup wizard goes into state RESTART (which
  assumes the setup wizard is done), and the setup wizard is skipped
  completely.
  
  This test expects that state NEW is retained upon restart when nothing
  is done.
  
  
  	
  JENKINS-47439 Persist InstallState
  
  
  
  In some cases, the heuristics to determine the current setup wizard state are
  fragile. It is safer to persist the install state so that upon restart,
  the setup wizard can resume where it was left off.
  
  
  	
  Missing javadoc and since for new public methods
  
  
  
  
  	
  s/XXX/FIXME/
  
  
  
  
  	
  Missed that one
  
  
  
  
  	
  Setup wizard filter should be removed when entering a state where setup is complete
  
  
  
  
  	
  Use parameterized logging
  
  
  
  
  	
  Improvements over previous impl
  
  
  
  
  	
  Removed static isUsingSecurityToken. Now only determined from install
  state.
  	
  Call onInstallStateUpdate before InstallState#initializeState as the
  latter can update state.
  
  
  
  
  	
  Triggering a new build
  
  
  
  (cherry picked from commit 30ab4481f286a5c33499489dfcb9b3df6587ff38)
  
  
  Compare: bed6ccd...c359b86
  
  

Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/java/hudson/util/PluginServletFilter.java
core/src/main/java/jenkins/install/InstallState.java
core/src/main/java/jenkins/install/InstallUtil.java
core/src/main/java/jenkins/install/SetupWizard.java
core/src/main/java/jenkins/model/Jenkins.java
test/src/test/java/jenkins/install/SetupWizardRestartTest.java
http://jenkins-ci.org/commit/jenkins/c359b86053dfe48c797f3b2135f72fb32cf8b609
Log:
[FIXES JENKINS-47439] Setup wizard does not resume after restart (#3166)

• JENKINS-47439 Add a failing test

On first startup, the setup wizard goes into state NEW and the filter to
force display the setup wizard is installed.

On second startup, the setup wizard goes into state RESTART (which
assumes the setup wizard is done), and the setup wizard is skipped
completely.

This test expects that state NEW is retained upon restart when nothing
is done.

• JENKINS-47439 Persist InstallState

In some cases, the heuristics to determine the current setup wizard state are
fragile. It is safer to persist the install state so that upon restart,
the setup wizard can resume where it was left off.

• Missing javadoc and since for new public methods

• s/XXX/FIXME/

• Missed that one

• Setup wizard filter should be removed when entering a state where setup is complete

• Use parameterized logging

• Improvements over previous impl

• Removed static isUsingSecurityToken. Now only determined from install
  state.
• Call onInstallStateUpdate before InstallState#initializeState as the
  latter can update state.

• Triggering a new build

(cherry picked from commit 30ab448)

Compare: bed6ccd...c359b86