Repository navigation
[JENKINS-47458] Trilead-SSH2 fails with NPE when calling Connection#getReasonClosedCause() #22371
Description
Just caught it in SSH Slaves plugin tests on my local machine:
Caused by: java.lang.NullPointerException at com.trilead.ssh2.Connection.getReasonClosedCause(Connection.java:1556) at hudson.plugins.sshslaves.SSHLauncher.reportTransportLoss(SSHLauncher.java:1420) at hudson.plugins.sshslaves.SSHLauncher.afterDisconnect(SSHLauncher.java:1343) at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:603) at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)
Tirlead code does not check whether "this.tm" field is null before returning getReasonClosedCause from "this.tm". Just a minor defect
Originally reported by 
oleg_nenashev, imported from: Trilead-SSH2 fails with NPE when calling Connection#getReasonClosedCause()
- assignee: oleg_nenashev
- status: Resolved
- priority: Minor
- component(s): core, trilead-api-plugin
- resolution: Fixed
- resolved: 2019-01-02T09:05:50+00:00
- votes: 0
- watchers: 2
- imported: 2025-11-24
Raw content of original issue
Just caught it in SSH Slaves plugin tests on my local machine:
Caused by: java.lang.NullPointerException at com.trilead.ssh2.Connection.getReasonClosedCause(Connection.java:1556) at hudson.plugins.sshslaves.SSHLauncher.reportTransportLoss(SSHLauncher.java:1420) at hudson.plugins.sshslaves.SSHLauncher.afterDisconnect(SSHLauncher.java:1343) at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:603) at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745)Tirlead code does not check whether "this.tm" field is null before returning getReasonClosedCause from "this.tm". Just a minor defect
Activity
jenkins-infra-bot commentedon Oct 16, 2017
Remote links associated with this issue:
jenkins-infra-bot commentedon Dec 25, 2018
Raw content of original comment:
jenkinsci/trilead-ssh2#25 was merged and released, but we need to upstream it to the core. CC ifernandezcalvo
jenkins-infra-bot commentedon Dec 28, 2018
Raw content of original comment:
The PRs to the core is in place