Repository navigation
[JENKINS-49906] Form validation considers the rename "no op" to be an error #22619
Description
Currently just going to the /job/whatever/confirmRename form results in a form validation error: "The name whatever is already in use".
Instead this should be an informational message about this being the current name, or something like that.
Originally reported by 
danielbeck, imported from: Form validation considers the rename "no op" to be an error
- assignee:
dnusbaum
- status: Resolved
- priority: Minor
- component(s): core
- resolution: Fixed
- resolved: 2018-03-11T18:11:46+00:00
- votes: 0
- watchers: 1
- imported: 2025-11-24
Raw content of original issue
Currently just going to the /job/whatever/confirmRename form results in a form validation error: "The name whatever is already in use".
Instead this should be an informational message about this being the current name, or something like that.
Activity
jenkins-infra-bot commentedon Mar 5, 2018
Remote link associated with this issue:
jenkins-infra-bot commentedon Mar 5, 2018
Raw content of original comment:
danielbeck what do you think about just leaving the name blank by default on that page? You'd still get an error ("No name is specified"), but since you have to pick something for the new name anyway that doesn't seem like a problem.
I can also improve the error message in the case where the name is the same as before to "The new name is identical to the current name".
EDIT: I should clarify, do you think renaming to the same name should succeed as a no-op, fail, or do something else?
jenkins-infra-bot commentedon Mar 5, 2018
Raw content of original comment:
I expect that it is rather likely that new job names will be similar to old job names, so would keep the default value to make minor changes easier. If you could detect it's the current job's name, just showing nothing, or an info message "same name" would be useful.
Not sure. Either could work. Since form submission that would change nothing is unlikely to be intended, it should probably remain an error.
jenkins-infra-bot commentedon Mar 5, 2018
Raw content of original comment:
It feels wrong to me to not show a message or to have an info message if it causes an error during submission. Would you be ok with just changing it from an error to a warning, and making the message more specific, or do you feel strongly that there should be no warnings or errors when the page is opened?
jenkins-infra-bot commentedon Mar 5, 2018
Raw content of original comment:
Warning (or unstyled info) would be fine, but it needs to be more specific than "name already taken". "Please specify a different name than the current one" or similar perhaps.
jenkins-infra-bot commentedon Mar 11, 2018
Raw content of original comment:
The patch has been integrated towards 2.111
jenkins-infra-bot commentedon Mar 12, 2018
Raw content of original comment:
This UI is not in 2.107.x.