Repository navigation
[JENKINS-23411] Parallel deletion of jobs from the ListView may lead to NPE errors #23187
Description
A report from Coverity:
*** CID 1222626: Dereference null return value (NULL_RETURNS)
/src/main/java/hudson/model/ListView.java: 334 in hudson.model.ListView.doRemoveJobFromView(java.lang.String)()
328 @RequirePOST
329 public HttpResponse doRemoveJobFromView(@QueryParameter String name) throws IOException, ServletException {
330 checkPermission(View.CONFIGURE);
331 if(name==null)
332 throw new Failure("Query parameter 'name' is required");
333
>>> CID 1222626: Dereference null return value (NULL_RETURNS)
>>> Assigning: "item" = null return value from "resolveName".
334 TopLevelItem item = resolveName(name);
335 if (remove(item))
336 owner.save();
337
338 return HttpResponses.ok();
339 }
Originally reported by 
oleg_nenashev, imported from: Parallel deletion of jobs from the ListView may lead to NPE errors
- assignee: liketic
- status: Resolved
- priority: Major
- component(s): core
- label(s): newbie-friendly
- resolution: Fixed
- resolved: 2017-09-24T17:14:01+00:00
- votes: 0
- watchers: 2
- imported: 2025-11-24
Raw content of original issue
A report from Coverity:
*** CID 1222626: Dereference null return value (NULL_RETURNS) /src/main/java/hudson/model/ListView.java: 334 in hudson.model.ListView.doRemoveJobFromView(java.lang.String)() 328 @RequirePOST 329 public HttpResponse doRemoveJobFromView(@QueryParameter String name) throws IOException, ServletException { 330 checkPermission(View.CONFIGURE); 331 if(name==null) 332 throw new Failure("Query parameter 'name' is required"); 333 >>> CID 1222626: Dereference null return value (NULL_RETURNS) >>> Assigning: "item" = null return value from "resolveName". 334 TopLevelItem item = resolveName(name); 335 if (remove(item)) 336 owner.save(); 337 338 return HttpResponses.ok(); 339 }
Activity
jenkins-infra-bot commentedon Sep 22, 2017
Raw content of original comment:
Code changed in jenkins
User: kel
Path:
core/src/main/java/hudson/model/ListView.java
test/src/test/java/hudson/model/ListViewTest.java
http://jenkins-ci.org/commit/jenkins/fddffb4fbceb50e0c8801044319e84dc6f9b7e90
Log:
[Fix JENKINS-23411] Throws Failure if the item does not exist (#3007)
jenkins-infra-bot commentedon Sep 24, 2017
Raw content of original comment:
Code changed in jenkins
User: liketic
Path:
test/src/test/java/hudson/model/ListViewTest.java
http://jenkins-ci.org/commit/jenkins/0b56fb5354b483f5a0f0860f587f5f3cc1b8d939
Log:
[Fix JENKINS-23411] Fix testing failure introduced in PR-3007
jenkins-infra-bot commentedon Sep 24, 2017
Raw content of original comment:
Code changed in jenkins
User: Oleg Nenashev
Path:
test/src/test/java/hudson/model/ListViewTest.java
http://jenkins-ci.org/commit/jenkins/49de269da88ff5aad87ef5971f0754816a308ae0
Log:
Merge pull request #3039 from liketic/bugfix/pull/3007
[Fix JENKINS-23411] Fix testing failure introduced in PR-3007
Compare: 3adfed4...49de269
jenkins-infra-bot commentedon Sep 24, 2017
Raw content of original comment:
Merged towards 2.80.
jenkins-infra-bot commentedon Dec 21, 2018
Raw content of original comment:
Some extra bits existed in #1276