Skip to content

[JENKINS-24625] style.css should define background color for input fields #23434

Closed
Bug
Closed
[JENKINS-24625] style.css should define background color for input fields#23434
Bug
Labels
component:coreimported-jira-issuepriority:minorresolution:fixedux

Description

@jenkins-infra-bot
jenkins-infra-bot
opened on Sep 8, 2014

Currently style.css sets the foreground color but doesn't set the background color; this renders all input fields unreadable for people with certain color schemes.

jenkins/war/src/main/webapp/css/style.css

Line 115 in 7cdb85d

body, table, form, input, td, th, p, textarea, select

To reproduce on Windows: Switch the Windows theme to High Contract and open a job configuration page.

To reproduce on Linux: Switch your theme to one where you have dark backgrounds and light text.

To solve this, add 'background-color: #fff' to the same definition.

Originally reported by quinox, imported from: style.css should define background color for input fields
  • status: Resolved
  • priority: Minor
  • component(s): core
  • label(s): user-experience
  • resolution: Fixed
  • resolved: 2014-09-13T16:27:38+00:00
  • votes: 0
  • watchers: 5
  • imported: 2025-11-24
Raw content of original issue 
Currently style.css sets the foreground color but doesn't set the background color; this renders all input fields unreadable for people with certain color schemes.




  

    

      jenkins/war/src/main/webapp/css/style.css
    

    

         Line 115
      in
      7cdb85d
    

  

  

    


        

          
           body, table, form, input, td, th, p, textarea, select 
        

    

  







To reproduce on Windows: Switch the Windows theme to High Contract and open a job configuration page.



To reproduce on Linux: Switch your theme to one where you have dark backgrounds and light text.



To solve this, add 'background-color: #fff' to the same definition.
1 attachment

Activity

  1. jenkins-infra-bot commented on Sep 11, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 11, 2014
    Author
    quinox:
    • Original comment link
    • Raw content of original comment: 
      I can submit a pull request with the fixed CSS if that would help.

    I can submit a pull request with the fixed CSS if that would help.

  2. jenkins-infra-bot commented on Sep 11, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 11, 2014
    Author
    danielbeck:

    That would probably be a good idea (Tom, who's working on Jenkins UX, is currently on vacation). For advice related to that, see:
    https://wiki.jenkins-ci.org/display/JENKINS/Governance+Document#GovernanceDocument-Usingpullrequests
    https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories

  3. jenkins-infra-bot commented on Sep 11, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 11, 2014
    Author
    quinox:
    • Original comment link
    • Raw content of original comment: 
      Thanks for the help Daniel, made the pull request.
      


      For those who want to reproduce the bug: After switching your theme you might need to restart your browser before the color scheme becomes fully active (the window decoration changes right away). Also, Chrome/Chromium isn't affected by it because they seem to ignore the user's theme completely.
      


      There's no testcase; if these kinds of issues should be intercepted in the future Jenkins could incorporate some kind of CSS Lint in the validation process.

    Thanks for the help Daniel, made the pull request.

    For those who want to reproduce the bug: After switching your theme you might need to restart your browser before the color scheme becomes fully active (the window decoration changes right away). Also, Chrome/Chromium isn't affected by it because they seem to ignore the user's theme completely.

    There's no testcase; if these kinds of issues should be intercepted in the future Jenkins could incorporate some kind of CSS Lint in the validation process.

  4. jenkins-infra-bot commented on Sep 13, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 13, 2014
    Author
    scm_issue_link:

    Code changed in jenkins
    User: quinox
    Path:
    war/src/main/webapp/css/style.css
    http://jenkins-ci.org/commit/jenkins/143581e67fbcf971bfdadf2ad42535a6912caf73
    Log:
    [FIXED JENKINS-24625] Set background color on input elements

  5. jenkins-infra-bot
    closed this as completedon Sep 13, 2014

  6. jenkins-infra-bot commented on Sep 13, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 13, 2014
    Author
    scm_issue_link:

    Code changed in jenkins
    User: Daniel Beck
    Path:
    war/src/main/webapp/css/style.css
    http://jenkins-ci.org/commit/jenkins/2753fac18d6ead74d8f446abcebda659eab29155
    Log:
    Merge pull request #1394 from quinox/master

    [FIXED JENKINS-24625] Set background color on input elements

    Compare: 8cbd2b5...2753fac

  7. jenkins-infra-bot commented on Sep 13, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 13, 2014
    Author
    dogfood:

    Integrated in jenkins_main_trunk #3678
    [FIXED JENKINS-24625] Set background color on input elements (Revision 143581e)

    Result = SUCCESS
    quinox : 143581e67fbcf971bfdadf2ad42535a6912caf73
    Files :

    • war/src/main/webapp/css/style.css

  8. jenkins-infra-bot commented on Sep 15, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 15, 2014
    Author
    tfennelly:

    This change causes other small issues. Please see JENKINS-24703.

  9. jenkins-infra-bot commented on Sep 15, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 15, 2014
    Author
    tfennelly:
    • Original comment link
    • Raw content of original comment: 
      The description of this JIRA just says "Switch your theme to...".  Where exactly did you go to switch the theme?

    The description of this JIRA just says "Switch your theme to...". Where exactly did you go to switch the theme?

  10. jenkins-infra-bot commented on Sep 15, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 15, 2014
    Author
    danielbeck:
    • Original comment link
    • Raw content of original comment: 
      Cannot reproduce on Windows 8.1 with any of the four high contrast themes in IE 11 or Firefox 32. How can this be reproduced?

    Cannot reproduce on Windows 8.1 with any of the four high contrast themes in IE 11 or Firefox 32. How can this be reproduced?

  11. jenkins-infra-bot commented on Sep 15, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 15, 2014
    Author
    quinox:
    • Original comment link
    • Raw content of original comment: 
      I cannot reproduce it either on Windows 8.1 nor on Vista with Firefox/IE. Firefox 32 on Windows XP does have the problem:
      


      http://ghost.qtea.nl/tmp/jenkins-colors-winxp-firefox32.png
      


      Linux deals with this less well than Windows it seems, with both KDE and Gnome suffering from it.
      


      Re JENKINS-24703: Instead of my previous solution (the merged pull request) the background color can also be set on the body element: I still get good readable inputs.

    I cannot reproduce it either on Windows 8.1 nor on Vista with Firefox/IE. Firefox 32 on Windows XP does have the problem:

    http://ghost.qtea.nl/tmp/jenkins-colors-winxp-firefox32.png

    Linux deals with this less well than Windows it seems, with both KDE and Gnome suffering from it.

    Re JENKINS-24703: Instead of my previous solution (the merged pull request) the background color can also be set on the body element: I still get good readable inputs.

  12. jenkins-infra-bot commented on Sep 27, 2014

    @jenkins-infra-bot
    jenkins-infra-bot
    on Sep 27, 2014
    Author
    scm_issue_link:
    • Original comment link
    • Raw content of original comment: 
      Code changed in jenkins
User: Michal Turek
Path:
 src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
 src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/index.jelly
 src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly
http://jenkins-ci.org/commit/cppcheck-plugin/cb9f0426890e0b938ca711d18698a0007a8e9fb5
Log:
  JENKINS-24834 CPP check report background colours not displaying for new or resolved issues since upgrade
      


        
	
      • White background color was set to all TD elements in core's JENKINS-24625 which overwrote settings of outer TR.
        • 
	
      • Missing mandatory "title" element added to l:layout.
        •

    Code changed in jenkins
    User: Michal Turek
    Path:
    src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/details.jelly
    src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckResult/index.jelly
    src/main/resources/org/jenkinsci/plugins/cppcheck/CppcheckSourceAll/index.jelly
    http://jenkins-ci.org/commit/cppcheck-plugin/cb9f0426890e0b938ca711d18698a0007a8e9fb5
    Log:
    JENKINS-24834 CPP check report background colours not displaying for new or resolved issues since upgrade

    • White background color was set to all TD elements in core's JENKINS-24625 which overwrote settings of outer TR.
    • Missing mandatory "title" element added to l:layout.

  13. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 24, 2025
    Author

    [Original relates_to from Jira: JENKINS-24917]

  14. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 24, 2025
    Author

    [Original relates_to from Jira: JENKINS-24703]

  15. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 24, 2025
    Author

    [Original relates_to from Jira: JENKINS-24828]

  16. jenkins-infra-bot
    added
    bugFor changelog: Minor bug. Will be listed after features
    ux
    imported-jira-issue
    component:core
    priority:minor
    on Nov 24, 2025

  17. jenkins-infra-bot commented on Nov 24, 2025

    @jenkins-infra-bot
    jenkins-infra-bot
    on Nov 24, 2025
    Author

    [Original relates_to from Jira: JENKINS-24834]

  18. jenkins-infra-bot
    added
    resolution:fixed
    on Nov 24, 2025
  19. jenkins-infra-bot
    added the
    Bug
    issue type on Nov 25, 2025
  20. jenkins-infra-bot
    removed
    bugFor changelog: Minor bug. Will be listed after features
    on Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    component:coreimported-jira-issuepriority:minorresolution:fixedux

    Type

    Bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions