Repository navigation
[JENKINS-794] Hudson Plugin renaming causes dead absolute links in jelly files #23985
Description
The url the image referes is
"http:///hudson/plugin/tasks/icons/tasks-48x48.png" and on the menu
"http:///hudson/plugin/tasks/icons/tasks-24x24.png". However, the
webbrowser can't fetch them.
Originally reported by danielgalan, imported from: Hudson Plugin renaming causes dead absolute links in jelly files
- assignee:
kohsuke
- status: Closed
- priority: Major
- component(s): other
- resolution: Fixed
- resolved: 2008-03-22T12:59:51+00:00
- votes: 0
- watchers: 0
- imported: 2025-12-08
Raw content of original issue
The url the image referes is "http://<ourserver>/hudson/plugin/tasks/icons/tasks-48x48.png" and on the menu "http://<ourserver>/hudson/plugin/tasks/icons/tasks-24x24.png". However, the webbrowser can't fetch them.
- environment:
Platform: All, OS: All
Activity
jenkins-infra-bot commentedon Sep 6, 2007
danielgalan:
Raw content of original comment:
Created an attachment (id=86)
Images not found
jenkins-infra-bot commentedon Sep 6, 2007
danielgalan:
Raw content of original comment:
I use the latest versions, hudson 1.36 and tasks 1.5
jenkins-infra-bot commentedon Sep 6, 2007
Raw content of original comment:
Hmm, that is strange, I can't reproduce this.
Which browser are you using? Can it display PNG images?
Could you please check if the following files exist:
${HUDSON_HOME}/plugins/tasks/icons/tasks-24x24.png
${HUDSON_HOME}/plugins/tasks/icons/tasks-48x48.png
Then drag this files to your browser and check if these are correctly rendered.
jenkins-infra-bot commentedon Sep 6, 2007
danielgalan:
Raw content of original comment:
I'm using win2k here at work, Firefox 2.0.6.
I found the problem, I renamed the tasks.jar, so these files
${HUDSON_HOME}/plugins/tasks/icons/tasks-24x24.png
${HUDSON_HOME}/plugins/tasks/icons/tasks-48x48.png
exists in this directories
${HUDSON_HOME}/plugins/hudson-tasks-1.5/icons/tasks-24x24.png
${HUDSON_HOME}/plugins/hudson-tasks-1.5/icons/tasks-48x48.png
can you set the path depending on the plugin-name? I think you have access to
the pluginname, because in the installed pluginlist is the name
"hudson-tasks-1.5" listed.
Thanks
Daniel
jenkins-infra-bot commentedon Sep 12, 2007
Raw content of original comment:
From the DEV mailing list:
> Hi,
.
>
> is the actual directory (hpi-name) of a plugin programmatically available?
> My plugin does not find its images if someone renames the plugin from
tasks.hpi to tasks-1.5.hpi.
> since I use absolute references in the jelly script /tasks/path (as all other
plug-ins
>
> /plugin/findbugs/icons/findbugs-48x48.gif
Good point.
I think what we should do is to bake the real plugin name inside hpi, so
that Hudson always extract it using the real name, not the versioned
name taken from the maven repository.
–
Kohsuke Kawaguchi
Sun Microsystems kohsuke.kawaguchi@sun.com
jenkins-infra-bot commentedon Sep 12, 2007
Raw content of original comment:
I reassigned this issue since it better fits to the Hudson core. This
bug/problem will be present in any plugin that uses absolute links in jelly files.
jenkins-infra-bot commentedon Mar 22, 2008
Raw content of original comment:
Code changed in hudson
User: kohsuke
Path:
/hudson/hudson/plugins/pom.xml (1.194)
http://fisheye5.cenqua.com/changelog/hudson/?cs=MAIN:kohsuke:20080322195028
Log:
use 1.18 to pick up a fix toward issue #794. It also fixed a bug in computing the Hudson-Version manifest entry
jenkins-infra-bot commentedon Mar 22, 2008
Raw content of original comment:
Code changed in hudson
User: kohsuke
Path:
/hudson/www/changelog.html (1.1290)
http://fisheye5.cenqua.com/changelog/hudson/?cs=MAIN:kohsuke:20080322195613
Log:
Hudson won't be confused by renamed plugins now (issue #794)
jenkins-infra-bot commentedon Mar 22, 2008
Raw content of original comment:
Fixed in 1.201.
jenkins-infra-bot commentedon Mar 22, 2008
Raw content of original comment:
Code changed in hudson
User: kohsuke
Path:
/hudson/hudson/main/core/src/main/java/hudson/PluginWrapper.java (1.19)
http://fisheye5.cenqua.com/changelog/hudson/?cs=MAIN:kohsuke:20080322195520
Log:
[fixed] Hudson won't be confused by renamed plugins now (issue #794)