You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[JENKINS-1207] Reading the node list requires Admin privileges #24085
I guess we should consider just hiding some columns that may be considered
sensitive (like clock and disk space)? Or do you think it's safe to expose them all?
Feedback appreciated.
I guess we should consider just hiding some columns that may be considered
sensitive (like clock and disk space)? Or do you think it's safe to expose them all?
Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java
trunk/hudson/main/core/src/main/java/hudson/node_monitors/SwapSpaceMonitor.java
trunk/hudson/main/core/src/main/resources/hudson/model/ComputerSet/index.jelly
http://fisheye4.cenqua.com/changelog/hudson/?cs=14043
Log:
[FIXED JENKINS-1207] Don't require admin permission to view computer/ (node list) page.
Instead just hide disk-space and swap-space columns from the table.
Admin check was already there for "refresh" button at bottom of page.
Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java
trunk/hudson/main/core/src/main/java/hudson/node_monitors/SwapSpaceMonitor.java
trunk/hudson/main/core/src/main/resources/hudson/model/ComputerSet/index.jelly http://fisheye4.cenqua.com/changelog/hudson/?cs=14043
Log: [FIXED JENKINS-1207] Don't require admin permission to view computer/ (node list) page.
Instead just hide disk-space and swap-space columns from the table.
Admin check was already there for "refresh" button at bottom of page.
Activity
jenkins-infra-bot commentedon Jan 24, 2008
Raw content of original comment:
I guess we should consider just hiding some columns that may be considered
sensitive (like clock and disk space)? Or do you think it's safe to expose them all?
Feedback appreciated.
jenkins-infra-bot commentedon Jan 26, 2008
nidaley:
Raw content of original comment:
Hmm, good point Kohsuke. Yes, hiding the sensitive info would be much more user friendly. I think just
disk space should be hidden.
jenkins-infra-bot commentedon Dec 31, 2008
Raw content of original comment:
Working on this one. Hiding disk-space and swap-space columns from non-admins.
The "refresh" button and action already have an admin check.
jenkins-infra-bot commentedon Dec 31, 2008
Raw content of original comment:
setting to started.
jenkins-infra-bot commentedon Dec 31, 2008
Raw content of original comment:
Code changed in hudson
User: : mindless
Path:
trunk/hudson/main/core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java
trunk/hudson/main/core/src/main/java/hudson/node_monitors/SwapSpaceMonitor.java
trunk/hudson/main/core/src/main/resources/hudson/model/ComputerSet/index.jelly
http://fisheye4.cenqua.com/changelog/hudson/?cs=14043
Log:
[FIXED JENKINS-1207] Don't require admin permission to view computer/ (node list) page.
Instead just hide disk-space and swap-space columns from the table.
Admin check was already there for "refresh" button at bottom of page.