Repository navigation
[JENKINS-2366] Tag this build should be hidden #24337
Description
If a user is assigned Read only permission under overall, the link to Tag this
is visible. User is redirected to the login page after entering the url to
create the tag.
Tag this link should be visible only if the user has been assigned Tag
permission.
Originally reported by vijaysl, imported from: Tag this build should be hidden
- assignee:
mindless
- status: Closed
- priority: Major
- component(s): _unsorted
- resolution: Fixed
- resolved: 2008-12-30T14:26:05+00:00
- votes: 0
- watchers: 0
- imported: 2025-12-08
Raw content of original issue
If a user is assigned Read only permission under overall, the link to Tag this is visible. User is redirected to the login page after entering the url to create the tag.
Tag this link should be visible only if the user has been assigned Tag permission.
- environment:
Platform: All, OS: All
Activity
jenkins-infra-bot commentedon Dec 30, 2008
Raw content of original comment:
I don't see this problem now when the build has no tags already.. I see both
SubversionTagAction and CVSSCM.TagAction both check TAG permission and don't
show the link if there are no tags yet.
If the build does have a tag already, it does show the link (with different
text.. instead of "Tag this build" it could be "Subversion tag" for example)..
you can click this to see the existing tag(s).. the problem here is it also
shows the form to create a new tag even if you don't have permission. If you
submit the form it shows a permission error.
I'll make it hide the form if you can't use it..
jenkins-infra-bot commentedon Dec 30, 2008
Raw content of original comment:
Fixed in 1.269
r13988
main/core/src/main/java/hudson/scm/SubversionTagAction.java
main/core/src/main/java/hudson/scm/CVSSCM.java
main/core/src/main/resources/hudson/scm/SubversionTagAction/tagForm.jelly
main/core/src/main/resources/hudson/scm/CVSSCM/TagAction/tagForm.jelly