New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIXED JENKINS-20559 and JENKINS-19454] - hudson.Launcher bugfix and additional wrapper #1013
[FIXED JENKINS-20559 and JENKINS-19454] - hudson.Launcher bugfix and additional wrapper #1013
Conversation
core » jenkins_main_trunk #1538 UNSTABLE |
Probably better to have this in 2 different PRs. |
I can submit the fix without tests as a separate PR. |
@kutzi |
Yes, agreed. Empty array is preferable over null |
core » jenkins_main_trunk #1561 SUCCESS |
core » jenkins_main_trunk #1567 FAILURE |
core » jenkins_main_trunk #1568 UNSTABLE |
hudson.util.AlternativeUiTextProviderTest.testBasics returns "java.lang.IllegalStateException: second instance". Seems yi has been caused by previous commits... |
Yes I think that was @kohsuke’s regression. |
BTW, the PR is ready for further review and merge |
Hello, |
@olivergondza or @jglick |
* @author Oleg Nenashev <nenashev@synopsys.com>, Synopsys Inc. | ||
* @since TODO: define a version | ||
*/ | ||
public class ProcStarterTest extends JenkinsRule { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extending JenkinsRule
is rather unusual. Also @since
for TestCase is unnecessary.
Right. Otherwise the PR looks OK to me. |
Thanks a lot. |
Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
I've merged changes into several commits. A direct test for JENKINS-20559 goes in a seoarate commit in order to simplify LTS merge of synopsys-arc-oss@320a26d Unfortunately, seems that https://jenkins.ci.cloudbees.com/job/core/job/jenkins_main_trunk/ has gone to New Year holidays :( |
Try merging with |
core » jenkins-core #4 UNSTABLE |
core » jenkins-core #6 UNSTABLE |
core » jenkins-core #304 UNSTABLE |
… core. This launcher Allows subclasses to only implement methods they want to override. Originally, this launcher has been implemented in Custom Tools Plugin, but there are many duplicates in other plugins => it would be useful to have it in Jenkins core. Resolves https://issues.jenkins-ci.org/browse/JENKINS-19454 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
… environment variables list Resolves https://issues.jenkins-ci.org/browse/JENKINS-20559 BTW, I also need to add some tests to "Test Harness" in order to improve coverage of nested operations. These test require a fix for https://issues.jenkins-ci.org/browse/JENKINS-19454 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
core » jenkins-core #789 UNSTABLE |
core » jenkins-core #797 FAILURE |
core » jenkins-core #800 FAILURE |
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
core » jenkins-core #801 SUCCESS |
I've re-based changes and fixed the unit test according to comments. |
[FIXED JENKINS-20559 and JENKINS-19454] - hudson.Launcher bugfix and additional wrapper
Summary:
Noting:
<plaintext>