Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-22934] Show poll thread count option when necessary. #1230

Merged
merged 1 commit into from Jun 1, 2014

Conversation

3 participants
@daniel-beck
Copy link
Member

daniel-beck commented May 8, 2014

Old behavior:

  • Show the option when Jenkins has more than 10 children.

New behavior:

  • Only consider AbstractProjects
  • Also consider grandchildren etc. (i.e. in other ItemGroups)
  • Also show the option when the currently configured value is not the default to prevent reset
[FIXED JENKINS-22934] Show poll thread count option when necessary.
* Show the option when the configured value is not the default
* Show the option even when projects are in other ItemGroups
* Only consider AbstractProjects
@cloudbees-pull-request-builder

This comment has been minimized.

Copy link

cloudbees-pull-request-builder commented May 8, 2014

core » jenkins-core #658 SUCCESS
This pull request looks good

// so let's hide this option for new users to avoid confusing them
// unless it was already changed
return Jenkins.getInstance().getAllItems(AbstractProject.class).size() > 10
|| getPollingThreadCount() != 0;

This comment has been minimized.

@oleg-nenashev

oleg-nenashev May 9, 2014

Member

Is there any need to hide null values?
I suppose that the "SCM Polling" section will blink due to automatic page refreshes

This comment has been minimized.

@daniel-beck

daniel-beck May 10, 2014

Author Member

What are you referring to?

Note that I'm again only fixing the obvious brokenness here, not changing the basic behavior. While I disagree that the option should ever be hidden (and even consider the default of 0 to simply be stupid), I kept the existing behavior as much as made sense to me.

This comment has been minimized.

@oleg-nenashev

oleg-nenashev May 10, 2014

Member

My apologies. I have not noticed that you address the global configuration page.
I recall my comment, the change should be merged.

oleg-nenashev added a commit that referenced this pull request Jun 1, 2014

Merge pull request #1230 from daniel-beck/JENKINS-22934
[FIXED JENKINS-22934] Show poll thread count option when necessary.

@oleg-nenashev oleg-nenashev merged commit 91ef911 into jenkinsci:master Jun 1, 2014

oleg-nenashev added a commit that referenced this pull request Jun 1, 2014

Noting #1230
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.