[FIX JENKINS-22685] Jenkins cannot restart Windows service#1238
Merged
daniel-beck merged 1 commit intojenkinsci:masterfrom May 23, 2014
Merged
[FIX JENKINS-22685] Jenkins cannot restart Windows service#1238daniel-beck merged 1 commit intojenkinsci:masterfrom
daniel-beck merged 1 commit intojenkinsci:masterfrom
Conversation
|
core » jenkins-core #691 UNSTABLE |
|
core » jenkins-core #695 SUCCESS |
Member
|
The issue seems to be the LTS candidate |
… to properly restart the service. Using "restart!" instead of "restart" performs the restart in a separate process, so the service wrapper doesn't kill itself.
Contributor
Author
|
Done... hopefully correctly. Let me know if other changes are needed. |
Member
|
👍 |
daniel-beck
added a commit
that referenced
this pull request
May 23, 2014
[FIX JENKINS-22685] Jenkins cannot restart Windows service
|
core » jenkins-core #734 SUCCESS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "restart!" instead of "restart" when calling the Windows service wrapper to restart Jenkins. Otherwise, the service wrapper kills itself before completing the stop-wait-start procedure. JENKINS-22685 for issue description, and see Winsw README ("Restarting service from itself") for details about the use and intention of "restart!".