New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX JENKINS-22685] Jenkins cannot restart Windows service #1238

Merged
merged 1 commit into from May 23, 2014

Conversation

4 participants
@gmjck
Contributor

gmjck commented May 13, 2014

Use "restart!" instead of "restart" when calling the Windows service wrapper to restart Jenkins. Otherwise, the service wrapper kills itself before completing the stop-wait-start procedure. JENKINS-22685 for issue description, and see Winsw README ("Restarting service from itself") for details about the use and intention of "restart!".

@cloudbees-pull-request-builder

This comment has been minimized.

Show comment
Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder May 13, 2014

core » jenkins-core #691 UNSTABLE
Looks like there's a problem with this pull request

cloudbees-pull-request-builder commented May 13, 2014

core » jenkins-core #691 UNSTABLE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

This comment has been minimized.

Show comment
Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder commented May 13, 2014

core » jenkins-core #695 SUCCESS
This pull request looks good

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev May 23, 2014

Member

The issue seems to be the LTS candidate
Could you merge changes into one commit? It would be great if you explicitly reference the issue commit message. E.g. "[FIXED JENKINS-22685] - Call restart! to properly restart the Windows service"

Member

oleg-nenashev commented May 23, 2014

The issue seems to be the LTS candidate
Could you merge changes into one commit? It would be great if you explicitly reference the issue commit message. E.g. "[FIXED JENKINS-22685] - Call restart! to properly restart the Windows service"

[FIXED JENKINS-22685] - Update WindowsLifeCycle.java to call restart!…
… to properly restart the service.

Using "restart!" instead of "restart" performs the restart in a separate process, so the service wrapper doesn't kill itself.
@gmjck

This comment has been minimized.

Show comment
Hide comment
@gmjck

gmjck May 23, 2014

Contributor

Done... hopefully correctly. Let me know if other changes are needed.

Contributor

gmjck commented May 23, 2014

Done... hopefully correctly. Let me know if other changes are needed.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev
Member

oleg-nenashev commented May 23, 2014

👍

daniel-beck added a commit that referenced this pull request May 23, 2014

Merge pull request #1238 from gmjck/master
[FIX JENKINS-22685] Jenkins cannot restart Windows service

@daniel-beck daniel-beck merged commit f434c22 into jenkinsci:master May 23, 2014

daniel-beck added a commit that referenced this pull request May 23, 2014

@cloudbees-pull-request-builder

This comment has been minimized.

Show comment
Hide comment
@cloudbees-pull-request-builder

cloudbees-pull-request-builder commented May 23, 2014

core » jenkins-core #734 SUCCESS
This pull request looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment