Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get method for causes of interruption. #1712

Closed
wants to merge 2 commits into from

Conversation

lvotypko
Copy link
Member

No description provided.

@oleg-nenashev
Copy link
Member

👍 (Javadoc can be patched during the merge)

* @return Unmodifiable collection of causes of interruption
*
*/
public Collection<CauseOfInterruption> getCausesOfInterruption(){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nonnull ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@since and . on the end of sentences in javadoc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivergondza and space after () then ;)
And no new line after return line.

* Returns causes of interruption.
*
* @return Unmodifiable collection of causes of interruption.
* @since 1.617
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not actual now, please replace with TODO

@KostyaSha
Copy link
Member

Please fix since and squash, then 👍

@jglick
Copy link
Member

jglick commented Aug 21, 2015

Seems fine, though is there a specific use case you had in mind?

@oleg-nenashev oleg-nenashev added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Oct 11, 2015
oleg-nenashev pushed a commit that referenced this pull request Oct 17, 2015
oleg-nenashev added a commit that referenced this pull request Oct 17, 2015
@oleg-nenashev
Copy link
Member

Manually integrated as efa1487

@oleg-nenashev oleg-nenashev added merged and removed ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants