New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get method for causes of interruption. #1712
Conversation
👍 (Javadoc can be patched during the merge) |
* @return Unmodifiable collection of causes of interruption | ||
* | ||
*/ | ||
public Collection<CauseOfInterruption> getCausesOfInterruption(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nonnull
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@since
and .
on the end of sentences in javadoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olivergondza and space after ()
then ;)
And no new line after return line.
* Returns causes of interruption. | ||
* | ||
* @return Unmodifiable collection of causes of interruption. | ||
* @since 1.617 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not actual now, please replace with TODO
Please fix since and squash, then 👍 |
Seems fine, though is there a specific use case you had in mind? |
This pull request integrates #1712
Manually integrated as efa1487 |
No description provided.