Add get method for causes of interruption. #1712

Closed
wants to merge 2 commits into
from

Conversation

5 participants
@lvotypko
Member

lvotypko commented May 19, 2015

No description provided.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev May 21, 2015

Member

👍 (Javadoc can be patched during the merge)

Member

oleg-nenashev commented May 21, 2015

👍 (Javadoc can be patched during the merge)

+ * @return Unmodifiable collection of causes of interruption
+ *
+ */
+ public Collection<CauseOfInterruption> getCausesOfInterruption(){

This comment has been minimized.

@KostyaSha

KostyaSha May 21, 2015

Member

@Nonnull ?

@KostyaSha

KostyaSha May 21, 2015

Member

@Nonnull ?

This comment has been minimized.

@olivergondza

olivergondza May 22, 2015

Member

@since and . on the end of sentences in javadoc.

@olivergondza

olivergondza May 22, 2015

Member

@since and . on the end of sentences in javadoc.

This comment has been minimized.

@KostyaSha

KostyaSha May 26, 2015

Member

@olivergondza and space after () then ;)
And no new line after return line.

@KostyaSha

KostyaSha May 26, 2015

Member

@olivergondza and space after () then ;)
And no new line after return line.

+ * Returns causes of interruption.
+ *
+ * @return Unmodifiable collection of causes of interruption.
+ * @since 1.617

This comment has been minimized.

@KostyaSha

KostyaSha Aug 20, 2015

Member

not actual now, please replace with TODO

@KostyaSha

KostyaSha Aug 20, 2015

Member

not actual now, please replace with TODO

@KostyaSha

This comment has been minimized.

Show comment
Hide comment
@KostyaSha

KostyaSha Aug 20, 2015

Member

Please fix since and squash, then 👍

Member

KostyaSha commented Aug 20, 2015

Please fix since and squash, then 👍

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Aug 21, 2015

Member

Seems fine, though is there a specific use case you had in mind?

Member

jglick commented Aug 21, 2015

Seems fine, though is there a specific use case you had in mind?

oleg-nenashev added a commit that referenced this pull request Oct 17, 2015

oleg-nenashev added a commit that referenced this pull request Oct 17, 2015

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Oct 17, 2015

Member

Manually integrated as efa1487

Member

oleg-nenashev commented Oct 17, 2015

Manually integrated as efa1487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment