OptionalJobProperty #1888

Merged
merged 2 commits into from Nov 3, 2015

Conversation

5 participants
@jglick
Member

jglick commented Oct 27, 2015

Simplification to allow JobProperty implementations to be spared the messy details of defining a UI for an optional property, which is the normal case.

Alternative to #1656.

  • new API
  • demonstrate simplification of ParametersDefinitionProperty

@reviewbybees

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Oct 27, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@@ -311,3 +311,4 @@ UpdateCenter.DownloadButNotActivated=Descarga correcta. Se activar
Computer.ConnectPermission.Description=Este permiso permite que los usuarios puedan conectar nodos o marcarlos como activos.
BallColor.NotBuilt=Sin ejecutar.
AbstractBuild_Building=Ejecutando.
+ParametersDefinitionProperty.DisplayName=Esta ejecución debe parametrizarse

This comment has been minimized.

@amuniz

amuniz Oct 27, 2015

Contributor

Esta ejecución es parametrizada is a better translation.

@amuniz

amuniz Oct 27, 2015

Contributor

Esta ejecución es parametrizada is a better translation.

@amuniz

This comment has been minimized.

Show comment
Hide comment
@amuniz

amuniz Oct 27, 2015

Contributor

🐝 (as far as I understand the objective of this PR, since there is no JIRA ticket linked and only a short description: "new API", which is obvious).

Contributor

amuniz commented Oct 27, 2015

🐝 (as far as I understand the objective of this PR, since there is no JIRA ticket linked and only a short description: "new API", which is obvious).

@tfennelly

This comment has been minimized.

Show comment
Hide comment
@tfennelly

tfennelly Oct 27, 2015

Member

🐝

Member

tfennelly commented Oct 27, 2015

🐝

@jglick jglick referenced this pull request Oct 27, 2015

Merged

BuildDiscarderProperty #1889

@jglick

This comment has been minimized.

Show comment
Hide comment
Member

jglick commented Oct 30, 2015

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Oct 30, 2015

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@jglick jglick merged commit 600b1f0 into jenkinsci:master Nov 3, 2015

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:OptionalJobProperty branch Nov 3, 2015

daniel-beck added a commit that referenced this pull request Nov 5, 2015

@jglick jglick referenced this pull request in jenkinsci/acceptance-test-harness Nov 25, 2015

Merged

OptionalJobProperty updates #61

@bpedersen2

This comment has been minimized.

Show comment
Hide comment
@bpedersen2

bpedersen2 Nov 26, 2015

Contributor

Seems like this change could be the cause of: https://issues.jenkins-ci.org/browse/JENKINS-31733

Contributor

bpedersen2 commented Nov 26, 2015

Seems like this change could be the cause of: https://issues.jenkins-ci.org/browse/JENKINS-31733

@bpedersen2

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment