This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.
I agree that the \ in usernames non-ntlm could be a problem. This could be fixed (without breaking compatibility with previous configurations) by adding a configuration option (a checkbox) to indicate if you are using NTLM auth or not (disabled by default), so userName.indexOf('\\') >= 0 would be only checked if NTLM is active.
This is a 🐝 from me, but I would encourage you to consider that option.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.