Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-33828] - setup wizard was modifying the recommended plugin list #2190

Conversation

5 participants
@kzantow
Copy link
Contributor

commented Mar 29, 2016

The setup wizard was returning a reference to the recommended plugin array as the selected plugins, allowing it to be modified and resulting in unexpected behavior in certain cases.

This addresses: https://issues.jenkins-ci.org/browse/JENKINS-33828

@reviewbybees esp. @daniel-beck

@reviewbybees

This comment has been minimized.

Copy link

commented Mar 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

This comment has been minimized.

Copy link
Member

commented Mar 29, 2016

🐝

@gusreiber

This comment has been minimized.

Copy link

commented Mar 29, 2016

@kzantow After running this guy [ https://github.com/kzantow/jenkins/tree/JENKINS-33828-recommended-plugin-list-modifiable ] I am still seeing the same blank grid of plugins being installed. This is on Chrome OSX Version 49.0.2623.87 (64-bit)
🐤

@kzantow

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2016

@gusreiber what set of steps did you use to reproduce this? Also, are you running the .war or through Eclipse or something else?

@daniel-beck

This comment has been minimized.

Copy link
Member

commented Mar 29, 2016

When I select "None", then return ("Back" button) and select "Install recommended plugins", it installs a bunch of stuff, but all of them are considered dependencies (**). It's not a presentation issue (besides the fact that maybe dependencies should get a box as well, but whatever), but a data issue.

The other part -- "Recommended" not working properly -- is now resolved.

@gusreiber

This comment has been minimized.

Copy link

commented Mar 29, 2016

@kzantow @daniel-beck let me know if you want me to record a second issue. As far as I could understand it, I am still seeing exactly the same behavior described in 33828, with the same repro steps. Is that not what you are seeing, Daniel?

@daniel-beck

This comment has been minimized.

Copy link
Member

commented Mar 29, 2016

@gusreiber Please note that I did delete my previous wrong comments once I understood the problem. There used to be a JS issue that prevented the "grid" from appearing, so I misunderstood the issue as being about that here as well, when it's not. Jenkins just displays all of the plugins being installed as if they were dependencies.

Setup Wizard not actually displaying the selected plugins properly in
the case of: deselect (e.g. click None), Back, install recommended
@kzantow

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2016

@gusreiber please try this again, that was an embarrassing omission (could have sworn I tested that multiple times)

@gusreiber

This comment has been minimized.

Copy link

commented Mar 29, 2016

🐝 yup, that did it.

@jglick

This comment has been minimized.

Copy link
Member

commented Mar 29, 2016

🐝

1 similar comment
@daniel-beck

This comment has been minimized.

Copy link
Member

commented Mar 29, 2016

🐝

@daniel-beck daniel-beck merged commit 4d01c07 into jenkinsci:2.0 Mar 29, 2016

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.