Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX JENKINS-33891] scrollToPosition doesn't work in some conditions … #2193

Closed
wants to merge 1 commit into from

Conversation

6 participants
@gusreiber
Copy link

commented Mar 30, 2016

…in 1.0 not needed in 2.0

@reviewbybees

Not exactly sure how to handle this bug. The issue exists in v1 and doesn't seem to reproduce in Chrome. The old Jenkins config will attempt to scroll newly expanded divs from optional blocks into view, but because the page geometry is constantly changing, it often messes up the math. When it works, the behavior is nice enough, especially when a checkbox is at the bottom of the screen, but is mostly unnecessary fluff.

Personally, I would kill it from v1 as well.

gusreiber
@reviewbybees

This comment has been minimized.

Copy link

commented Mar 30, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@kzantow

This comment has been minimized.

Copy link
Contributor

commented Mar 30, 2016

🐝

//FIXME: This scrollIntoView behavior breaks in v1 with FF on OSX.
// The scrolling behavior doesn't seem to add much utility, so this conditionally
// removes it from the v2 config page.
var legacyConfig = $$('body.main-panel-only').length === 0;

This comment has been minimized.

Copy link
@recena

recena Mar 30, 2016

Contributor

@gusreiber Could we use another condition? I hope to remove main-panel-only soon when this PR #2029 is merged

This comment has been minimized.

Copy link
@recena

recena Mar 30, 2016

Contributor

Maybe checking data-version="jenkins-1.642.2"?

@daniel-beck

This comment has been minimized.

Copy link
Member

commented Mar 30, 2016

Given the apparently rare conditions in which this appears, and the fact that it is not a regression from 1.x, I'm declining this for 2.0. 2.1, more likely.

Thanks @gusreiber for figuring this out!

@tlopesPT

This comment has been minimized.

Copy link

commented Jun 29, 2016

This PR is not fixing the issue on 2.10, I believe it's because "main-body-panel" was removed on PR #2253

It would be great to have the issue fixed on 2.x.

p.s.: this issue seems to be directly related with the inline="true" property of the optionalBlock, if it is not set there's no issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.