Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
[FIX JENKINS-33891] scrollToPosition doesn't work in some conditions … #2193
…in 1.0 not needed in 2.0
Not exactly sure how to handle this bug. The issue exists in v1 and doesn't seem to reproduce in Chrome. The old Jenkins config will attempt to scroll newly expanded divs from optional blocks into view, but because the page geometry is constantly changing, it often messes up the math. When it works, the behavior is nice enough, especially when a checkbox is at the bottom of the screen, but is mostly unnecessary fluff.
Personally, I would kill it from v1 as well.
This PR is not fixing the issue on 2.10, I believe it's because "main-body-panel" was removed on PR #2253
It would be great to have the issue fixed on 2.x.
p.s.: this issue seems to be directly related with the inline="true" property of the optionalBlock, if it is not set there's no issue.