Add French translation for Jenkins 2.0 wizard #2267

Merged
merged 1 commit into from Apr 22, 2016

Conversation

5 participants
@jpbriend
Contributor

jpbriend commented Apr 15, 2016

I added the French translation for the new Jenkins 2 startup wizard.
I had to tokenize some jelly files.
If this format is ok, I'll push some other translations for the new Jenkins 2 stuff.

@jpbriend

This comment has been minimized.

Show comment
Hide comment
Contributor

jpbriend commented Apr 15, 2016

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Apr 15, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@kzantow kzantow closed this Apr 15, 2016

@kzantow kzantow reopened this Apr 15, 2016

@kzantow

This comment has been minimized.

Show comment
Hide comment
@kzantow

kzantow Apr 15, 2016

Contributor

👍 LGTM

A note: you CAN use backslash in properties files (but it can get ugly), for example:

This\ is\ something\ with\ spaces=<some translation here>

Contributor

kzantow commented Apr 15, 2016

👍 LGTM

A note: you CAN use backslash in properties files (but it can get ugly), for example:

This\ is\ something\ with\ spaces=<some translation here>

@kzantow kzantow closed this Apr 15, 2016

@kzantow kzantow reopened this Apr 15, 2016

@jpbriend

This comment has been minimized.

Show comment
Hide comment
@jpbriend

jpbriend Apr 15, 2016

Contributor

@kzantow I tried with backslashed-spaces as you suggested but I also find this gets ugly for the eyes.

Contributor

jpbriend commented Apr 15, 2016

@kzantow I tried with backslashed-spaces as you suggested but I also find this gets ugly for the eyes.

@kzantow

This comment has been minimized.

Show comment
Hide comment
@kzantow

kzantow Apr 15, 2016

Contributor

🐝

Contributor

kzantow commented Apr 15, 2016

🐝

@@ -0,0 +1,13 @@
+authenticate-security-token.getting.started=D\u00e9marrage

This comment has been minimized.

@batmat

batmat Apr 15, 2016

Member

NIT: as .properties files are by definition encoded into ISO-8859-1, I think this would be easier to just write 'Démarrage' instead for readability reasons.
I fixed something in a translation file some times ago because some character was actually written twice, but that would only be really visible rendered in the UI. (OK, with an editor that would support rendering it, that might be less of an issue, but still in a PR it's more complex to review).

@batmat

batmat Apr 15, 2016

Member

NIT: as .properties files are by definition encoded into ISO-8859-1, I think this would be easier to just write 'Démarrage' instead for readability reasons.
I fixed something in a translation file some times ago because some character was actually written twice, but that would only be really visible rendered in the UI. (OK, with an editor that would support rendering it, that might be less of an issue, but still in a PR it's more complex to review).

This comment has been minimized.

@jpbriend

jpbriend Apr 18, 2016

Contributor

@batmat I had the same question and noticed all translated files are using unicode characters. I thought this was to help prevent someone to commit accidently with a bad encoding so I stuck with existing convention (2016, still annoyed with encoding...).
Thank you for the remark, it confirmed my analysis.

@jpbriend

jpbriend Apr 18, 2016

Contributor

@batmat I had the same question and noticed all translated files are using unicode characters. I thought this was to help prevent someone to commit accidently with a bad encoding so I stuck with existing convention (2016, still annoyed with encoding...).
Thank you for the remark, it confirmed my analysis.

@@ -0,0 +1,3 @@
+msg.before=Bienvenue sur Jenkins 2!\u0020

This comment has been minimized.

@batmat

batmat Apr 15, 2016

Member

Jenkins 2 !

Missing unbreakable space between Jenkins and 2.

@batmat

batmat Apr 15, 2016

Member

Jenkins 2 !

Missing unbreakable space between Jenkins and 2.

This comment has been minimized.

@jpbriend

jpbriend Apr 18, 2016

Contributor

2 pais of eyes are better than one, good catch.
I correct this one by amending the commit.

@jpbriend

jpbriend Apr 18, 2016

Contributor

2 pais of eyes are better than one, good catch.
I correct this one by amending the commit.

@batmat

This comment has been minimized.

Show comment
Hide comment
@batmat

batmat Apr 15, 2016

Member

👍 cool work. It's so rare to find translations w/o a lot of typos or mistakes, so congrats! :-)

Member

batmat commented Apr 15, 2016

👍 cool work. It's so rare to find translations w/o a lot of typos or mistakes, so congrats! :-)

@jpbriend jpbriend closed this Apr 18, 2016

@jpbriend jpbriend reopened this Apr 18, 2016

@daniel-beck daniel-beck merged commit e1dc525 into jenkinsci:master Apr 22, 2016

1 check passed

Jenkins This pull request looks good
Details

@jpbriend jpbriend deleted the jpbriend:translation_french_jenkins20_wizard branch May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment