Lithuanian translation update #2286

Merged
merged 7 commits into from Apr 28, 2016

Conversation

2 participants
@tomass
Contributor

tomass commented Apr 23, 2016

No description provided.

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Apr 25, 2016

Member

This looks like a work in progress, given the number of English descriptions in the Lithuanian properties file.

Member

daniel-beck commented Apr 25, 2016

This looks like a work in progress, given the number of English descriptions in the Lithuanian properties file.

@tomass

This comment has been minimized.

Show comment
Hide comment
@tomass

tomass Apr 25, 2016

Contributor

One of the files does have a lot of still untranslated items (and there are still a lot of other properties files which still have no Lithuanian versions yet). But there are a lot of other translations in this PR which would be nice to see in weekly builds of 2.0. To test/check/validate.
It the PR is "too small", what would be the limit?

Contributor

tomass commented Apr 25, 2016

One of the files does have a lot of still untranslated items (and there are still a lot of other properties files which still have no Lithuanian versions yet). But there are a lot of other translations in this PR which would be nice to see in weekly builds of 2.0. To test/check/validate.
It the PR is "too small", what would be the limit?

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Apr 25, 2016

Member

It the PR is "too small", what would be the limit?

Not about it being too small, it's just that having any strings in the localized Messages file will make tools consider them to be already translated. So I recommend you remove untranslated (English) placeholder strings in your Lithuanian resource file.

Member

daniel-beck commented Apr 25, 2016

It the PR is "too small", what would be the limit?

Not about it being too small, it's just that having any strings in the localized Messages file will make tools consider them to be already translated. So I recommend you remove untranslated (English) placeholder strings in your Lithuanian resource file.

@tomass

This comment has been minimized.

Show comment
Hide comment
@tomass

tomass Apr 25, 2016

Contributor

I have finished translating the file in question. Not sure if github will pick it up and merge into the same PR (i'm not an expert in git/github).
If I remove non translated strings then it will be much harder to find untranslated strings later...

Contributor

tomass commented Apr 25, 2016

I have finished translating the file in question. Not sure if github will pick it up and merge into the same PR (i'm not an expert in git/github).
If I remove non translated strings then it will be much harder to find untranslated strings later...

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Apr 25, 2016

Member

@tomass The PR is updated. Thank you. I wonder whether someone in the project team speaks Lithuanian… @jenkinsci/code-reviewers any idea?

Member

daniel-beck commented Apr 25, 2016

@tomass The PR is updated. Thank you. I wonder whether someone in the project team speaks Lithuanian… @jenkinsci/code-reviewers any idea?

@tomass

This comment has been minimized.

Show comment
Hide comment
@tomass

tomass Apr 26, 2016

Contributor

Same question about somebody speaking Lithuanian was asked in my previous PR. Nobody showed up in 3 months:
#1990

Contributor

tomass commented Apr 26, 2016

Same question about somebody speaking Lithuanian was asked in my previous PR. Nobody showed up in 3 months:
#1990

@daniel-beck daniel-beck self-assigned this Apr 26, 2016

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Apr 28, 2016

Member

@tomass Good point. In that case, since all strings appear to be translated now, I'll go ahead and merge. Thanks!

Member

daniel-beck commented Apr 28, 2016

@tomass Good point. In that case, since all strings appear to be translated now, I'll go ahead and merge. Thanks!

@daniel-beck daniel-beck merged commit fc2234c into jenkinsci:master Apr 28, 2016

1 check passed

Jenkins This pull request looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment