New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying custom AbortExceptions #2288

Merged
merged 1 commit into from May 9, 2016

Conversation

4 participants
@KostyaSha
Member

KostyaSha commented Apr 25, 2016

Workflow users may want to catch specific Exceptions without stracktrace in future.

Logically it shouldn't be final because it possible to make Exceptions with stacktraces and impossible without. WDYT?


This change is Reviewable

Allow specifying custom AbortExceptions
Workflow users may want to catch specific Exceptions without stracktrace in future.
@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Apr 25, 2016

Member

Is it not sufficient to provide a message here in the AbortException(String) constructor? What's the advantage of subtypes? I mean, you don't want to catch them, do you? The whole point is that these aren't caught…

Member

daniel-beck commented Apr 25, 2016

Is it not sufficient to provide a message here in the AbortException(String) constructor? What's the advantage of subtypes? I mean, you don't want to catch them, do you? The whole point is that these aren't caught…

@KostyaSha

This comment has been minimized.

Show comment
Hide comment
@KostyaSha

KostyaSha Apr 25, 2016

Member

Differentiate step errors i.e. ConfigurationException SomeOtherTypeOfKnownException, unknown will go to rethrow with exception as usual.

Member

KostyaSha commented Apr 25, 2016

Differentiate step errors i.e. ConfigurationException SomeOtherTypeOfKnownException, unknown will go to rethrow with exception as usual.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev May 3, 2016

Member

I think the change makes sense 👍
Maybe some developer documentation in the class would help

Member

oleg-nenashev commented May 3, 2016

I think the change makes sense 👍
Maybe some developer documentation in the class would help

@batmat

This comment has been minimized.

Show comment
Hide comment
@batmat

batmat May 8, 2016

Member

Don't see where that could really hurt. So 👍

Member

batmat commented May 8, 2016

Don't see where that could really hurt. So 👍

@oleg-nenashev oleg-nenashev merged commit f4765d9 into jenkinsci:master May 9, 2016

1 check passed

Jenkins This pull request looks good
Details

batmat added a commit to batmat/jenkins that referenced this pull request May 10, 2016

batmat added a commit to batmat/jenkins that referenced this pull request May 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment