Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-33596] disable UDP broadcast & jmDNS by default, make configurable #2301

Closed
wants to merge 5 commits into from

Conversation

@kzantow
Copy link
Contributor

kzantow commented Apr 29, 2016

Moves configuration for jmDNS and UDP broadcast from Jenkins constructor to global security configuration items.

Addresses: https://issues.jenkins-ci.org/browse/JENKINS-33596

TODO:

  • Ensure upgrading from prior versions results in these services being enabled as they were
@daniel-beck
Copy link
Member

daniel-beck commented Apr 30, 2016

Would it make sense to introduce a network-discovery plugin, that bundles these features and possibly a fixed version #1301?

CC @jglick who IIRC said in the past that UDP broadcast and DNS multicast should be a new plugin.

@daniel-beck
Copy link
Member

daniel-beck commented Apr 30, 2016

FWIW I think even if it's a separate plugin, having UI options for this is useful. So these changes (detach + configurable) are complementary.

@kzantow
Copy link
Contributor Author

kzantow commented May 2, 2016

@daniel-beck right, I was taking a piecemeal approach to this... side note: I don't want to be the maintainer of the network-discovery plugin :)

Jenkins jenkins = Jenkins.getInstance();
jenkins.checkPermission(Jenkins.ADMINISTER);

// for compatibility reasons, the actual value is stored in Jenkins

This comment has been minimized.

Copy link
@amuniz

amuniz May 6, 2016

Member

But the fields were removed from Jenkins, so I guess this information is stored now in its own XML file, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.