Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[JENKINS-33596] disable UDP broadcast & jmDNS by default, make configurable #2301
Conversation
|
FWIW I think even if it's a separate plugin, having UI options for this is useful. So these changes (detach + configurable) are complementary. |
|
@daniel-beck right, I was taking a piecemeal approach to this... side note: I don't want to be the maintainer of the network-discovery plugin :) |
| Jenkins jenkins = Jenkins.getInstance(); | ||
| jenkins.checkPermission(Jenkins.ADMINISTER); | ||
|
|
||
| // for compatibility reasons, the actual value is stored in Jenkins |
This comment has been minimized.
This comment has been minimized.
amuniz
May 6, 2016
Member
But the fields were removed from Jenkins, so I guess this information is stored now in its own XML file, no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kzantow commentedApr 29, 2016
Moves configuration for jmDNS and UDP broadcast from
Jenkinsconstructor to global security configuration items.Addresses: https://issues.jenkins-ci.org/browse/JENKINS-33596
TODO: