Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-29922] Correct the default value handling of ArtifactArchiver.excludes #2484

Merged

Conversation

4 participants
@jglick
Copy link
Member

jglick commented Jul 27, 2016

Noted in JENKINS-29922 that Snippet Generator as of 2.7.1 will produce

archiveArtifacts artifacts: 'x', excludes: null

whereas

archiveArtifacts 'x'

would suffice.

Same applies to the older $class-based syntax, it is just more noticeable now, since I would like to push the stock ArtifactArchiver in place of the dedicated archive step.

@reviewbybees

@@ -155,19 +156,7 @@ public void testAllowEmptyArchive() throws Exception {
assertFalse(kids[0].exists());
j.createWebClient().assertFails(b.getUrl() + "artifact/hack", HttpURLConnection.HTTP_NOT_FOUND);
}

private void runNewBuildAndStartUnitlIsCreated(AbstractProject project) throws InterruptedException{

This comment has been minimized.

Copy link
@jglick

jglick Jul 27, 2016

Author Member

Was unused.

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 27, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

This comment has been minimized.

Copy link
Member

abayer commented Jul 27, 2016

🐝

1 similar comment
@kohsuke

This comment has been minimized.

Copy link
Member

kohsuke commented Jul 27, 2016

🐝

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Jul 27, 2016

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 27, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@jglick

This comment has been minimized.

Copy link
Member Author

jglick commented Jul 28, 2016

Test failures are unrelated; @rtyler / @abayer FYI the UC JSON appears to be broken. These “online” tests really need to be ripped out of core.

@jglick jglick merged commit 81bc2ef into jenkinsci:master Jul 28, 2016

1 check failed

Jenkins Looks like there's a problem with this pull request
Details

@jglick jglick deleted the jglick:ArtifactArchiver.excludes-JENKINS-29922 branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.