New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-36757] don't quote a paramaterized message. #2494

Merged
merged 1 commit into from Aug 7, 2016

Conversation

3 participants
@jtnord
Member

jtnord commented Aug 4, 2016

'{0}' is the literal string {0} in a message format - if you want to quote
the parameter then you need to use double single quotes ''{0}''

@reviewbybees
JENKINS-36757

[JENKINS-36757] don't quote a paramaterized message.
'{0}' is the literal string {0} in a message format - if you want to quote
the parameter then you need to use double single quotes ''{0}''
@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Aug 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Aug 4, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev
Member

oleg-nenashev commented Aug 4, 2016

🐝

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 7, 2016

Member

@reviewbybees done
Merging since the issue and fix are pretty obvious

Member

oleg-nenashev commented Aug 7, 2016

@reviewbybees done
Merging since the issue and fix are pretty obvious

@oleg-nenashev oleg-nenashev merged commit 03750c9 into jenkinsci:master Aug 7, 2016

1 check passed

Jenkins This pull request looks good
Details

olivergondza added a commit that referenced this pull request Aug 17, 2016

[JENKINS-36757] don't quote a paramaterized message in UpdateCenter. (#…
…2494)

'{0}' is the literal string {0} in a message format - if you want to quote
the parameter then you need to use double single quotes ''{0}''
(cherry picked from commit 03750c9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment