New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED JENKINS-37189] Only append `?uctest` to http/https update center URLs #2500

Merged
merged 2 commits into from Aug 9, 2016

Conversation

10 participants
@stephenc
Member

stephenc commented Aug 8, 2016

  • Also fixes to append &uctest if the update center URL already contains a query fragment

@jenkinsci/code-reviewers @reviewbybees

@olivergondza can we get an exemption so that this can be included in the backports for 2.7.3?

[FIXED JENKINS-37189] Only append `?uctest` to http/https update cent…
…er URLs

- Also fixes to append `&uctest` if the update center URL already contains a query fragment
@amuniz

This comment has been minimized.

Show comment
Hide comment
@amuniz

amuniz Aug 8, 2016

Contributor

🐝

Contributor

amuniz commented Aug 8, 2016

🐝

@recena

This comment has been minimized.

Show comment
Hide comment
@recena

recena Aug 8, 2016

Contributor

🐝

Contributor

recena commented Aug 8, 2016

🐝

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Aug 8, 2016

Member

🐝

Member

jglick commented Aug 8, 2016

🐝

@jtnord

This comment has been minimized.

Show comment
Hide comment
@jtnord

jtnord Aug 8, 2016

Member

🐝 /cc @andresrc

Member

jtnord commented Aug 8, 2016

🐝 /cc @andresrc

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Aug 8, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Aug 8, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@stephenc

This comment has been minimized.

Show comment
Hide comment
@stephenc
Member

stephenc commented Aug 8, 2016

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Aug 8, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

reviewbybees commented Aug 8, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 8, 2016

Member

Oh well, PR builder...

12:46:18 [ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (default) on project pom: Execution default of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed: A required class was missing while executing org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check: org/objectweb/asm/ClassVisitor
12:46:18 [ERROR] -----------------------------------------------------
Member

oleg-nenashev commented Aug 8, 2016

Oh well, PR builder...

12:46:18 [ERROR] Failed to execute goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check (default) on project pom: Execution default of goal org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check failed: A required class was missing while executing org.codehaus.mojo:animal-sniffer-maven-plugin:1.15:check: org/objectweb/asm/ClassVisitor
12:46:18 [ERROR] -----------------------------------------------------
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev
Member

oleg-nenashev commented Aug 8, 2016

🐝

@andresrc

This comment has been minimized.

Show comment
Hide comment
@andresrc

andresrc Aug 9, 2016

Contributor

🐝

Contributor

andresrc commented Aug 9, 2016

🐝

@olivergondza

This comment has been minimized.

Show comment
Hide comment
@olivergondza

olivergondza Aug 9, 2016

Member

No unittest?

Member

olivergondza commented Aug 9, 2016

No unittest?

@stephenc

This comment has been minimized.

Show comment
Hide comment
@stephenc

stephenc Aug 9, 2016

Member

@olivergondza happy now? ;-)

Member

stephenc commented Aug 9, 2016

@olivergondza happy now? ;-)

[JENKINS-37189] Refactor to make more testable
- A pure unit tests will suffice

@olivergondza olivergondza reopened this Aug 9, 2016

@olivergondza

This comment has been minimized.

Show comment
Hide comment
@olivergondza
Member

olivergondza commented Aug 9, 2016

👍

@stephenc stephenc merged commit 04be71b into jenkinsci:master Aug 9, 2016

1 check was pending

Jenkins Jenkins is validating pull request ...
Details

@stephenc stephenc deleted the stephenc:jenkins-37189 branch Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment