New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sezpoz 1.12 #2525

Merged
merged 1 commit into from Sep 9, 2016

Conversation

4 participants
@jglick
Member

jglick commented Aug 29, 2016

@daniel-beck requested some better diagnostics about META-INF/annotations/hudson.Extension, which this release provides.

Upstream changes

@reviewbybees

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Aug 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

reviewbybees commented Aug 29, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Aug 29, 2016

Member

Not yet in Central apparently, will need to close & reopen in a few hours. (Would be nice if our CI builders could pick it up directly.)

Member

jglick commented Aug 29, 2016

Not yet in Central apparently, will need to close & reopen in a few hours. (Would be nice if our CI builders could pick it up directly.)

@andresrc

This comment has been minimized.

Show comment
Hide comment
@andresrc

andresrc Aug 29, 2016

Contributor

🐝

Contributor

andresrc commented Aug 29, 2016

🐝

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 30, 2016

Member

🐜 From what I see there are binary incompatible changes in the library. I do not see impact on the Jenkins core and OSS plugins, but as always there may be closed-source plugins. Do you see a risk in it?

Member

oleg-nenashev commented Aug 30, 2016

🐜 From what I see there are binary incompatible changes in the library. I do not see impact on the Jenkins core and OSS plugins, but as always there may be closed-source plugins. Do you see a risk in it?

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Aug 30, 2016

Member

there are binary incompatible changes in the library

Where?

Member

jglick commented Aug 30, 2016

there are binary incompatible changes in the library

Where?

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 31, 2016

Member

@jglick
Indexer6 to Indexer renaming: jglick/sezpoz@3d86479

Member

oleg-nenashev commented Aug 31, 2016

@jglick
Indexer6 to Indexer renaming: jglick/sezpoz@3d86479

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Aug 31, 2016

Member

That issue could be easily fixed by creating deprecated Indexer6 class, which would inherit Indexer

Member

oleg-nenashev commented Aug 31, 2016

That issue could be easily fixed by creating deprecated Indexer6 class, which would inherit Indexer

@jglick

This comment has been minimized.

Show comment
Hide comment
@jglick

jglick Aug 31, 2016

Member

Indexer6 to Indexer renaming

Compatible. This was in an implementation package, since it is used only via service registration, and even then only during compilation not runtime.

Member

jglick commented Aug 31, 2016

Indexer6 to Indexer renaming

Compatible. This was in an implementation package, since it is used only via service registration, and even then only during compilation not runtime.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 9, 2016

Member

If it's compilation-only, then it's fine
🐝 and @reviewbybees done

Member

oleg-nenashev commented Sep 9, 2016

If it's compilation-only, then it's fine
🐝 and @reviewbybees done

@oleg-nenashev oleg-nenashev merged commit ca5c597 into jenkinsci:master Sep 9, 2016

1 check passed

Jenkins This pull request looks good
Details

@jglick jglick deleted the jglick:sezpoz-1.12 branch Sep 9, 2016

daniel-beck added a commit that referenced this pull request Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment