New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SSHD module 1.7 (JENKINS-36420, etc.) #2534

Merged
merged 1 commit into from Sep 5, 2016

Conversation

4 participants
@oleg-nenashev
Member

oleg-nenashev commented Sep 2, 2016

Summary of changes:

Full diff: jenkinsci/sshd-module@sshd-1.6...sshd-1.7

@reviewbybees @aheritier

Update to SSHD module 1.7
Summary of changes:

* [JENKINS-36420](https://issues.jenkins-ci.org/browse/JENKINS-36420) - Allow setting up the the client idle timeout
* Upgrade to the new parent POM
* FindBugs cleanup, in particular jenkinsci/sshd-module@66162e7
@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Sep 2, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@aheritier

This comment has been minimized.

Show comment
Hide comment
Member

aheritier commented Sep 2, 2016

🐝 thx @oleg-nenashev

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
Member

oleg-nenashev commented Sep 3, 2016

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Sep 3, 2016

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging.

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Sep 3, 2016

Member

I'd have liked seeing jenkinsci/sshd-module#5 as well.

Member

daniel-beck commented Sep 3, 2016

I'd have liked seeing jenkinsci/sshd-module#5 as well.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 3, 2016

Member

@daniel-beck I agree, but it definitely requires some reviews and impact investigation before merging. Do you agree with a single fix integration for now?

Member

oleg-nenashev commented Sep 3, 2016

@daniel-beck I agree, but it definitely requires some reviews and impact investigation before merging. Do you agree with a single fix integration for now?

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 5, 2016

Member

Merging this PR since 1.7 release is available in any case.
@daniel-beck can follow-up on jenkinsci/sshd-module#5 in a new PR with update to 1.8

Member

oleg-nenashev commented Sep 5, 2016

Merging this PR since 1.7 release is available in any case.
@daniel-beck can follow-up on jenkinsci/sshd-module#5 in a new PR with update to 1.8

@oleg-nenashev oleg-nenashev merged commit d154604 into jenkinsci:master Sep 5, 2016

1 check passed

Jenkins This pull request looks good
Details
@aheritier

This comment has been minimized.

Show comment
Hide comment
Member

aheritier commented Sep 5, 2016

YEAHHH thx @oleg-nenashev

daniel-beck added a commit that referenced this pull request Sep 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment