New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serbian [sr] translation of properties files #2554

Merged
merged 1 commit into from Sep 23, 2016

Conversation

4 participants
@aleksdjuricin

aleksdjuricin commented Sep 19, 2016

Jelly view files to follow.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 20, 2016

Member

@jenkinsci/code-reviewers I doubt we have people, who can review this change.
@rtyler Maybe the call on Twitter / dev/user ML?

Member

oleg-nenashev commented Sep 20, 2016

@jenkinsci/code-reviewers I doubt we have people, who can review this change.
@rtyler Maybe the call on Twitter / dev/user ML?

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Sep 20, 2016

Member

I doubt anyone will care to validate translations done with cyrillic unicode codes...

Member

imod commented Sep 20, 2016

I doubt anyone will care to validate translations done with cyrillic unicode codes...

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 20, 2016

Member

@imod As a happy Cyrillic language speaker, I commonly checkout Russian translation PRs and then review them in an editor, which shows such properties properly.

Member

oleg-nenashev commented Sep 20, 2016

@imod As a happy Cyrillic language speaker, I commonly checkout Russian translation PRs and then review them in an editor, which shows such properties properly.

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Sep 20, 2016

Member

@oleg-nenashev I guess I just did not know that there is an easy way to do it :)

Member

imod commented Sep 20, 2016

@oleg-nenashev I guess I just did not know that there is an easy way to do it :)

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Sep 22, 2016

Member

@lksndr To clarify, do you plan to amend this PR, or is it mergeable as-is and you will file further PRs?

Member

daniel-beck commented Sep 22, 2016

@lksndr To clarify, do you plan to amend this PR, or is it mergeable as-is and you will file further PRs?

@aleksdjuricin

This comment has been minimized.

Show comment
Hide comment
@aleksdjuricin

aleksdjuricin Sep 22, 2016

@daniel-beck It's mergeable; additional work would be in a subsequent PR.
@imod This functionality is available in IDEA under File->Settings->Editor->File Encodings->Transparent native-to-ascii conversion, and I'm sure in other editors as well.

aleksdjuricin commented Sep 22, 2016

@daniel-beck It's mergeable; additional work would be in a subsequent PR.
@imod This functionality is available in IDEA under File->Settings->Editor->File Encodings->Transparent native-to-ascii conversion, and I'm sure in other editors as well.

@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Sep 22, 2016

Member

👍 A superficial check of the translations back to English indicates sane translations, except some domain specific terms Google has a problem with. I think that's all we can do here.

Member

daniel-beck commented Sep 22, 2016

👍 A superficial check of the translations back to English indicates sane translations, except some domain specific terms Google has a problem with. I think that's all we can do here.

@imod

This comment has been minimized.

Show comment
Hide comment
@imod

imod Sep 22, 2016

Member

👍 @lksndr, cool I did not know about it

Member

imod commented Sep 22, 2016

👍 @lksndr, cool I did not know about it

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Sep 22, 2016

Member

Retriggering the PR build, but 👍 from me.

Member

oleg-nenashev commented Sep 22, 2016

Retriggering the PR build, but 👍 from me.

@oleg-nenashev oleg-nenashev reopened this Sep 22, 2016

@daniel-beck daniel-beck reopened this Sep 22, 2016

@daniel-beck daniel-beck merged commit 627d3a3 into jenkinsci:master Sep 23, 2016

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

oleg-nenashev added a commit that referenced this pull request Oct 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment