New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present stacktrace when throwable attached to Descriptor.FormException #2555

Merged
merged 2 commits into from Sep 21, 2016

Conversation

3 participants
@olivergondza
Member

olivergondza commented Sep 20, 2016

Form submission can yield an error screen showing nothing but javax.servlet.ServletException: java.lang.NullPointerException presuming it needs no further explanation as it delegate to hudson.model.Failure.

This change makes sure then when there is a cause in FormException, its stacktrace is presented to the user.

@oleg-nenashev

Looks good to me, but I would change the annotation type

@olivergondza

This comment has been minimized.

Show comment
Hide comment
@olivergondza

olivergondza Sep 21, 2016

Member

@CheckForNull it is.

Member

olivergondza commented Sep 21, 2016

@CheckForNull it is.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev
Member

oleg-nenashev commented Sep 21, 2016

👍

@KostyaSha

👍

@olivergondza olivergondza merged commit f191a3d into jenkinsci:master Sep 21, 2016

1 check was pending

Jenkins Jenkins is validating pull request ...
Details

daniel-beck added a commit that referenced this pull request Sep 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment