[JENKINS-38539, JENKINS-37539] Update remoting from 2.62 to 2.62.2 #2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.61 does not exist, there was an issue during the release Changes in 2.62: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622 * [JENKINS-38539](https://issues.jenkins-ci.org/browse/JENKINS-38539) - Stability: Turn on SO_KEEPALIVE and provide CLI option to turn it off again. (jenkinsci/remoting#110) * [JENKINS-37539](https://issues.jenkins-ci.org/browse/JENKINS-37539) - Prevent <code>NullPointerException</code> in <code>Engine#connect()</code> when host or port parameters are <code>null</code> or empty. (jenkinsci/remoting#101) * [CID-152201] - Fix resource leak in <code>remoting.jnlp.Main</code>. (jenkinsci/remoting#102) * [CID-152200,CID-152202] - Resource leak in Encryption Cipher I/O streams on exceptional paths. (jenkinsci/remoting#104)
oleg-nenashev
added
the
needs-more-reviews
Copy & paste problem? Why would either of these matter when this goes from 2.62 to 2.62.2? |
|
@daniel-beck |
|
Code review diff: jenkinsci/remoting@remoting-2.62...remoting-2.62.2 |
daniel-beck
approved these changes
Oct 9, 2016
|
BTW, my TODO is to add proper |
oleg-nenashev
added
ready-for-merge
|
Was just a timeout, previous build was fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.62.1 does not exist, there was an issue during the release
Changes in 2.62.2: https://github.com/jenkinsci/remoting/blob/stable-2.x/CHANGELOG.md#2622
Stability: Turn on SO_KEEPALIVE and provide CLI option to turn it off again.
([FIXED JENKINS-38539] Turn on SO_KEEPALIVE and provide CLI option to turn it off again remoting#110)
Prevent
NullPointerExceptioninEngine#connect()when host or port parameters arenullor empty.([FIXED JENKINS-37539] - Prevent NPE in Engine#connect() when host or port are null or empty remoting#101)
Fix resource leak in
remoting.jnlp.Main.([CID-152201] - Fix resource leak in remoting.jnlp.Main remoting#102)
Resource leak in Encryption Cipher I/O streams on exceptional paths.
([CID-152200,CID-152202] - Resource leak in Cipher I/O streams on exceptional paths remoting#104)
@jenkinsci/code-reviewers