Update the detached version of Maven plugin to 2.14 #2606

Merged
merged 2 commits into from Oct 30, 2016

Conversation

5 participants
@oleg-nenashev
Member

oleg-nenashev commented Oct 30, 2016

It's a follow-up to #2568
The plan was to bump the detached version, but we didn't do it in time

CC @reviewbybees @jenkinsci/code-reviewers @aheritier @KostyaSha

@reviewbybees

This comment has been minimized.

Show comment
Hide comment
@reviewbybees

reviewbybees Oct 30, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Oct 30, 2016

Member

@kohsuke please do not release without this fix

On Oct 30, 2016 16:46, "Code Reviewed by CloudBees" <
notifications@github.com> wrote:

This pull request originates from a CloudBees https://www.cloudbees.com/
employee. At CloudBees, we require that all pull requests be reviewed by
other CloudBees employees before we seek to have the change accepted. If
you want to learn more about our process please see this explanation
https://github.com/reviewbybees/about#about-reviewbybees.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2606 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC3IoEXbpYi_ui2kbgXolPaHTBeWOe66ks5q5J_GgaJpZM4KkYIH
.

Member

oleg-nenashev commented Oct 30, 2016

@kohsuke please do not release without this fix

On Oct 30, 2016 16:46, "Code Reviewed by CloudBees" <
notifications@github.com> wrote:

This pull request originates from a CloudBees https://www.cloudbees.com/
employee. At CloudBees, we require that all pull requests be reviewed by
other CloudBees employees before we seek to have the change accepted. If
you want to learn more about our process please see this explanation
https://github.com/reviewbybees/about#about-reviewbybees.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2606 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC3IoEXbpYi_ui2kbgXolPaHTBeWOe66ks5q5J_GgaJpZM4KkYIH
.

@aheritier

This comment has been minimized.

Show comment
Hide comment
@aheritier

aheritier Oct 30, 2016

Member

🐝 +1

Le dimanche 30 octobre 2016, Oleg Nenashev notifications@github.com a
écrit :

@kohsuke please do not release without this fix

On Oct 30, 2016 16:46, "Code Reviewed by CloudBees" <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

This pull request originates from a CloudBees <
https://www.cloudbees.com/>
employee. At CloudBees, we require that all pull requests be reviewed by
other CloudBees employees before we seek to have the change accepted. If
you want to learn more about our process please see this explanation
https://github.com/reviewbybees/about#about-reviewbybees.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2606 (comment),
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoEXbpYi_
ui2kbgXolPaHTBeWOe66ks5q5J_GgaJpZM4KkYIH>
.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2606 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKqCMQzDH4ttqTxqKhvMUjwB0DJJpqjks5q5LJdgaJpZM4KkYIH
.


Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier

Member

aheritier commented Oct 30, 2016

🐝 +1

Le dimanche 30 octobre 2016, Oleg Nenashev notifications@github.com a
écrit :

@kohsuke please do not release without this fix

On Oct 30, 2016 16:46, "Code Reviewed by CloudBees" <
notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

This pull request originates from a CloudBees <
https://www.cloudbees.com/>
employee. At CloudBees, we require that all pull requests be reviewed by
other CloudBees employees before we seek to have the change accepted. If
you want to learn more about our process please see this explanation
https://github.com/reviewbybees/about#about-reviewbybees.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2606 (comment),
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC3IoEXbpYi_
ui2kbgXolPaHTBeWOe66ks5q5J_GgaJpZM4KkYIH>
.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2606 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKqCMQzDH4ttqTxqKhvMUjwB0DJJpqjks5q5LJdgaJpZM4KkYIH
.


Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Oct 30, 2016

Member

The build has failed horribly:

name="hudson.PluginWrapper$PluginWrapperAdministrativeMonitor" action="/administrativeMonitor/hudson.PluginWrapper$PluginWrapperAdministrativeMonitor/act"><div style="float:right"><input name="correct" type="submit" value="Correct" class="submit-button primary" /></div></form>
               There are dependency errors loading some plugins:
               <ul><li>Maven Integration plugin v2.14
                           <ul><li>JUnit Plugin v1.2-beta-4 is older than required. To fix, install v1.6 or later.</li></ul></li></ul></div></div><div class="am-message"><div class="warning"><form method="post" name="jenkins.diagnostics.SecurityIsOffMonitor" action="/administrativeMonitor/jenkins.diagnostics.SecurityIsOffMonitor/act"><div style="float:right"><input name="yes" type="submit" value="Setup Security" class="submit-button primary" /><input name="no" type="submit" value="Dismiss" class="submit-button primary" /></div>
             Unsecured Jenkins allows anyone on the network to launch processes on your behalf. Consider at least enabling authentication to discourage misuse.
           </form></div></div><p style="text-align: center; margin: 10px 0 0 0;"><a onclick="document.location.href='/manage';" href="/manage">Manage Jenkins</a></p></div></div><script type="text/javascript">
                   document.getElementById("header").appendChild(document.getElementById("visible-am-container"));
               </script><div id="l10n-dialog" class="dialog"></div><div id="l10n-footer" style="display:none; float:left"><a href="#" onclick="return showTranslationDialog();"><img src="/static/243a6f2c/plugin/translation/flags.png" />
             Help us localize this page
           </a></div><script>var footer = document.getElementById('l10n-footer');
           var f = document.getElementById('footer');
           f.insertBefore(footer,f.firstChild);
           footer.style.display="block";

           var translation={}; 
           translation.bundles = 
Member

oleg-nenashev commented Oct 30, 2016

The build has failed horribly:

name="hudson.PluginWrapper$PluginWrapperAdministrativeMonitor" action="/administrativeMonitor/hudson.PluginWrapper$PluginWrapperAdministrativeMonitor/act"><div style="float:right"><input name="correct" type="submit" value="Correct" class="submit-button primary" /></div></form>
               There are dependency errors loading some plugins:
               <ul><li>Maven Integration plugin v2.14
                           <ul><li>JUnit Plugin v1.2-beta-4 is older than required. To fix, install v1.6 or later.</li></ul></li></ul></div></div><div class="am-message"><div class="warning"><form method="post" name="jenkins.diagnostics.SecurityIsOffMonitor" action="/administrativeMonitor/jenkins.diagnostics.SecurityIsOffMonitor/act"><div style="float:right"><input name="yes" type="submit" value="Setup Security" class="submit-button primary" /><input name="no" type="submit" value="Dismiss" class="submit-button primary" /></div>
             Unsecured Jenkins allows anyone on the network to launch processes on your behalf. Consider at least enabling authentication to discourage misuse.
           </form></div></div><p style="text-align: center; margin: 10px 0 0 0;"><a onclick="document.location.href='/manage';" href="/manage">Manage Jenkins</a></p></div></div><script type="text/javascript">
                   document.getElementById("header").appendChild(document.getElementById("visible-am-container"));
               </script><div id="l10n-dialog" class="dialog"></div><div id="l10n-footer" style="display:none; float:left"><a href="#" onclick="return showTranslationDialog();"><img src="/static/243a6f2c/plugin/translation/flags.png" />
             Help us localize this page
           </a></div><script>var footer = document.getElementById('l10n-footer');
           var f = document.getElementById('footer');
           f.insertBefore(footer,f.firstChild);
           footer.style.display="block";

           var translation={}; 
           translation.bundles = 
@daniel-beck

This comment has been minimized.

Show comment
Hide comment
@daniel-beck

daniel-beck Oct 30, 2016

Member

As this is a necessary, discussed and apparently accepted followup to the other PR which was just not amended, 👍

Member

daniel-beck commented Oct 30, 2016

As this is a necessary, discussed and apparently accepted followup to the other PR which was just not amended, 👍

@batmat

This comment has been minimized.

Show comment
Hide comment
@batmat

batmat Oct 30, 2016

Member

👍

Member

batmat commented Oct 30, 2016

👍

@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Oct 30, 2016

Member

🚢 🇮🇹

Member

oleg-nenashev commented Oct 30, 2016

🚢 🇮🇹

@oleg-nenashev oleg-nenashev merged commit a9a4b95 into master Oct 30, 2016

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/branch This commit looks good
Details

@oleg-nenashev oleg-nenashev deleted the oleg-nenashev-patch-1 branch Oct 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment