Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-39454] Do not consider pendings from scheduleInternal #2609

Merged
merged 1 commit into from Nov 5, 2016

Conversation

4 participants
@jglick
Copy link
Member

commented Nov 2, 2016

Hard to explain, so read JENKINS-39454.

@reviewbybees

[FIXED JENKINS-39454] Do not consider pendings when deciding whether …
…a schedule result should be new or existing, as we have already taken a snapshot of actions.
@@ -1414,7 +1423,7 @@ public void maintain() {
p.task.getFullDisplayName());
p.isPending = false;
pendings.remove(p);
makeBuildable(p);
makeBuildable(p); // TODO whatever this is for, the return value is being ignored, so this does nothing at all

This comment has been minimized.

Copy link
@jglick

jglick Nov 2, 2016

Author Member

Looks like an unrelated bug. See #2510; we occasionally get here, but I have never figured out what this case means, and apparently this line does absolutely nothing. Maybe a regression from #1513? Clearly not covered by any existing tests.

jglick added a commit to jglick/pipeline-build-step-plugin that referenced this pull request Nov 2, 2016

@reviewbybees

This comment has been minimized.

Copy link

commented Nov 2, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@oleg-nenashev

This comment has been minimized.

Copy link
Member

commented Nov 4, 2016

Needs some testing in the field, but 🐝after reading the ticket and googling for the code.
@reviewbybees done

@oleg-nenashev oleg-nenashev merged commit a57b52e into jenkinsci:master Nov 5, 2016

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

oleg-nenashev added a commit that referenced this pull request Nov 6, 2016

@jglick jglick deleted the jglick:pendings-JENKINS-39454 branch Nov 6, 2016

@jglick jglick referenced this pull request Nov 6, 2016

Merged

Various fixes for hanging `build` steps #9

3 of 3 tasks complete

jglick added a commit to jglick/pipeline-build-step-plugin that referenced this pull request Nov 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.