Annotate localizer generated Messages classes with NoExternalUse

[daniel-beck]

Also update to localizer 1.24 which adds support for this.

Using another component's Messages is brittle and always risky, so let's make sure anyone with a recent enough core dependency and using the access-modifier-checker gets an error during build.

This will not break plugins at runtime, just make sure they don't reuse core Messages during build. In time, reuse should fade as core dependencies get updated.

[oleg-nenashev]

👍

[KostyaSha]

Wouldn't this enforce people to copy-paste information?

[daniel-beck]

@KostyaSha Depends. I don't expect there to be a lot of reuse of strings, and past experience points to plugins breaking because nobody really considers Messages.properties to be public (stable) API – similar to doWhatever methods that change signature depending on need e.g. to add a StaplerRequest argument. So I prefer to be cautious to prevent unnecessary breakage rather than trying to micro-optimize something.

[KostyaSha]

Yes it makes sense. What about help files? i'm using them i.e. for slave description.

[daniel-beck]

@KostyaSha I wouldn't rely too much on those either, at least unless they're based on public non-Restricted databound fields with the default naming convention. In that case, I'd say you're pretty safe from changes.

And FWIW the worst that happens there is that the Jenkins UI displays an error. With Messages (and implicit web methods), it's runtime exceptions and brokenness.

[KostyaSha]

let's try it could be reverted any time