Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX JENKINS-38175] Fix various ManagementLink related bugs #2692

Merged
merged 1 commit into from Jan 8, 2017

Conversation

daniel-beck
Copy link
Member

  1. In the context menu, the 'post' flag was set iff 'requiresConfirmation' was set, even though they're independent (e.g. 'Prepare for shutdown' requires the former but not the latter)
  2. /manage screen: The icon (t:summary) does not support POST or confirmation links, but was set to not link only if no confirmation was required (i.e. POST links did not POST when the icon was clicked -- now the icon is not clickable as a workaround, just like for confirmation links)
  3. /manage screen: All links requiring confirmation did POST, which masked the fact that the 'Reload from disk' link wasn't set up to require POST (it was only broken in the context menu). Now, confirmation and POST are separate flags, and 'Reload from disk' link correctly requests POST.

- In the context menu, the 'post' flag was set iff 'requiresConfirmation'
  was set, even though they're independent (e.g. Prepare for shutdown
  requires the former but not the latter)
- /manage screen: The icon (t:summary) does not support POST or
  confirmation links, but was set to not link only if no confirmation
  was required (i.e. POST links did not POST when the icon was clicked
  -- now the icon is not clickable as a workaround)
- /manage screen: All links requiring confirmation did POST, which masked
  the fact that the 'Reload from disk' link wasn't set up to require POST
  (it was only broken in the context menu). Now, confirmation and POST are
  separate flags, and 'Reload from disk' link now requests POST.
@daniel-beck daniel-beck added the needs-more-reviews Complex change, which would benefit from more eyes label Jan 2, 2017
@stephenc
Copy link
Member

stephenc commented Jan 4, 2017

🐝

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@oleg-nenashev oleg-nenashev merged commit f7ef77b into jenkinsci:master Jan 8, 2017
@oleg-nenashev
Copy link
Member

I will create a follow-up issue for the third bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-reviews Complex change, which would benefit from more eyes
Projects
None yet
3 participants