New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX JENKINS-38175] Fix various ManagementLink related bugs #2692

Merged
merged 1 commit into from Jan 8, 2017

Conversation

3 participants
@daniel-beck
Member

daniel-beck commented Jan 2, 2017

  1. In the context menu, the 'post' flag was set iff 'requiresConfirmation' was set, even though they're independent (e.g. 'Prepare for shutdown' requires the former but not the latter)
  2. /manage screen: The icon (t:summary) does not support POST or confirmation links, but was set to not link only if no confirmation was required (i.e. POST links did not POST when the icon was clicked -- now the icon is not clickable as a workaround, just like for confirmation links)
  3. /manage screen: All links requiring confirmation did POST, which masked the fact that the 'Reload from disk' link wasn't set up to require POST (it was only broken in the context menu). Now, confirmation and POST are separate flags, and 'Reload from disk' link correctly requests POST.
[FIX JENKINS-38175] Fix various ManagementLink related bugs
- In the context menu, the 'post' flag was set iff 'requiresConfirmation'
  was set, even though they're independent (e.g. Prepare for shutdown
  requires the former but not the latter)
- /manage screen: The icon (t:summary) does not support POST or
  confirmation links, but was set to not link only if no confirmation
  was required (i.e. POST links did not POST when the icon was clicked
  -- now the icon is not clickable as a workaround)
- /manage screen: All links requiring confirmation did POST, which masked
  the fact that the 'Reload from disk' link wasn't set up to require POST
  (it was only broken in the context menu). Now, confirmation and POST are
  separate flags, and 'Reload from disk' link now requests POST.
@stephenc

This comment has been minimized.

Show comment
Hide comment
@stephenc

stephenc Jan 4, 2017

Member

🐝

Member

stephenc commented Jan 4, 2017

🐝

@oleg-nenashev

LGTM 👍

@oleg-nenashev oleg-nenashev merged commit f7ef77b into jenkinsci:master Jan 8, 2017

2 checks passed

Jenkins This pull request looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
@oleg-nenashev

This comment has been minimized.

Show comment
Hide comment
@oleg-nenashev

oleg-nenashev Jan 8, 2017

Member

I will create a follow-up issue for the third bug

Member

oleg-nenashev commented Jan 8, 2017

I will create a follow-up issue for the third bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment